From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 3/4] Add: set_online and post_online methods to isimodem driver
Date: Thu, 27 May 2010 07:48:21 -0500 [thread overview]
Message-ID: <201005270748.21704.denkenz@gmail.com> (raw)
In-Reply-To: <AANLkTilgxwBpRZHSUB1oVNAhVELPLPFnOaKVdxpLFYIo@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 781 bytes --]
Hi Pekka,
> 2010/5/27 Denis Kenzior <denkenz@gmail.com>:
> >> +static bool mtc_state_cb(GIsiClient *client, const void *restrict data,
> >> + size_t len, uint16_t object, void *opaque)
> >
> > We don't use bools in oFono, please fix this to use gboolean or an int.
>
> Huh?
>
> int ofono_modem_set_boolean(struct ofono_modem *modem,
> const char *key, bool value);
> bool ofono_modem_get_boolean(struct ofono_modem *modem, const char *key);
Then that is a bug and needs to be fixed to use ofono_bool_t. Things do
sometimes fall through the cracks...
>
> There are also some inconsistent usage of ofono_bool_t and
> dbus_bool_t, mostly they are assumed to be the same type.
>
Patches are welcome.
Regards,
-Denis
next prev parent reply other threads:[~2010-05-27 12:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1274885889-11479-2-git-send-email-Pekka.Pessi@nokia.com>
2010-05-26 14:58 ` [PATCH 3/4] Add: set_online and post_online methods to isimodem driver Pekka Pessi
2010-05-27 2:08 ` Denis Kenzior
2010-05-27 6:48 ` Aki Niemi
2010-05-27 11:44 ` Denis Kenzior
2010-05-27 12:34 ` Pekka Pessi
2010-05-27 12:48 ` Denis Kenzior [this message]
2010-05-27 16:12 ` [PATCH 1/6] Use ofono_bool_t instead of bool in modem API Pekka Pessi
2010-05-27 16:12 ` [PATCH 2/6] Use ofono_bool_t with D-Bus API Pekka Pessi
2010-05-27 16:12 ` [PATCH 3/6] Eliminated bool, true and false from gisi Pekka Pessi
2010-05-27 16:12 ` [PATCH 4/6] Eliminated bool, true and false from isimodem Pekka Pessi
2010-05-27 16:12 ` [PATCH 5/6] Fixed style issues in isimodem voicecall Pekka Pessi
2010-05-27 16:12 ` [PATCH 6/6] Add: set_online and post_online methods to isimodem driver Pekka Pessi
2010-05-27 19:36 ` [PATCH 3/6] Eliminated bool, true and false from gisi Denis Kenzior
2010-05-27 18:02 ` [PATCH 2/6] Use ofono_bool_t with D-Bus API Denis Kenzior
2010-05-27 18:01 ` [PATCH 1/6] Use ofono_bool_t instead of bool in modem API Denis Kenzior
2010-05-25 21:14 [PATCH 2/4] Add: test scripts online-modem and offline-modem Pekka Pessi
2010-05-25 21:14 ` [PATCH 3/4] Add: set_online and post_online methods to isimodem driver Pekka Pessi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201005270748.21704.denkenz@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox