From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 2/6] Use ofono_bool_t with D-Bus API.
Date: Thu, 27 May 2010 13:02:53 -0500 [thread overview]
Message-ID: <201005271302.53682.denkenz@gmail.com> (raw)
In-Reply-To: <1274976768-1555-2-git-send-email-Pekka.Pessi@nokia.com>
[-- Attachment #1: Type: text/plain, Size: 526 bytes --]
Hi Pekka,
> if (modem->powered_pending == FALSE) {
> DBusConnection *conn = ofono_dbus_get_connection();
> - dbus_bool_t powered = FALSE;
> -
> modem->powered = FALSE;
> ofono_dbus_signal_property_changed(conn, modem->path,
> OFONO_MODEM_INTERFACE,
> "Powered", DBUS_TYPE_BOOLEAN,
> - &powered);
> + &modem->powered);
Actually this is the preferred approach and is more type safe. If you notice
cases where we don't do this, then please send a patch.
Regards,
-Denis
next prev parent reply other threads:[~2010-05-27 18:02 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1274885889-11479-2-git-send-email-Pekka.Pessi@nokia.com>
2010-05-26 14:58 ` [PATCH 3/4] Add: set_online and post_online methods to isimodem driver Pekka Pessi
2010-05-27 2:08 ` Denis Kenzior
2010-05-27 6:48 ` Aki Niemi
2010-05-27 11:44 ` Denis Kenzior
2010-05-27 12:34 ` Pekka Pessi
2010-05-27 12:48 ` Denis Kenzior
2010-05-27 16:12 ` [PATCH 1/6] Use ofono_bool_t instead of bool in modem API Pekka Pessi
2010-05-27 16:12 ` [PATCH 2/6] Use ofono_bool_t with D-Bus API Pekka Pessi
2010-05-27 16:12 ` [PATCH 3/6] Eliminated bool, true and false from gisi Pekka Pessi
2010-05-27 16:12 ` [PATCH 4/6] Eliminated bool, true and false from isimodem Pekka Pessi
2010-05-27 16:12 ` [PATCH 5/6] Fixed style issues in isimodem voicecall Pekka Pessi
2010-05-27 16:12 ` [PATCH 6/6] Add: set_online and post_online methods to isimodem driver Pekka Pessi
2010-05-27 19:36 ` [PATCH 3/6] Eliminated bool, true and false from gisi Denis Kenzior
2010-05-27 18:02 ` Denis Kenzior [this message]
2010-05-27 18:01 ` [PATCH 1/6] Use ofono_bool_t instead of bool in modem API Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201005271302.53682.denkenz@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox