* [PATCH] network: query signal strength when status changes to registered or roaming.
@ 2010-12-03 15:00 Marit Henriksen
2010-12-15 14:01 ` Marit Sofie Henriksen
2010-12-16 18:52 ` Gustavo F. Padovan
0 siblings, 2 replies; 3+ messages in thread
From: Marit Henriksen @ 2010-12-03 15:00 UTC (permalink / raw)
To: ofono
[-- Attachment #1: Type: text/plain, Size: 2053 bytes --]
From: Marit Henriksen <marit.henriksen@stericsson.com>
Signal strength is set to -1 whenever registration status changes
and differs from registered or roaming. When registration status
changes again to registered or roaming, the signal strength needs to
be updated, so add query towards driver to get it.
---
src/network.c | 29 ++++++++++++++++-------------
1 files changed, 16 insertions(+), 13 deletions(-)
diff --git a/src/network.c b/src/network.c
index d5b42a1..80fa83d 100644
--- a/src/network.c
+++ b/src/network.c
@@ -1296,6 +1296,19 @@ emit:
notify_status_watches(netreg);
}
+static void signal_strength_callback(const struct ofono_error *error,
+ int strength, void *data)
+{
+ struct ofono_netreg *netreg = data;
+
+ if (error->type != OFONO_ERROR_TYPE_NO_ERROR) {
+ DBG("Error during signal strength query");
+ return;
+ }
+
+ ofono_netreg_strength_notify(netreg, strength);
+}
+
void ofono_netreg_status_notify(struct ofono_netreg *netreg, int status,
int lac, int ci, int tech)
{
@@ -1319,6 +1332,9 @@ void ofono_netreg_status_notify(struct ofono_netreg *netreg, int status,
if (netreg->driver->current_operator)
netreg->driver->current_operator(netreg,
current_operator_callback, netreg);
+ if (netreg->driver->strength)
+ netreg->driver->strength(netreg,
+ signal_strength_callback, netreg);
} else {
struct ofono_error error;
@@ -1345,19 +1361,6 @@ void ofono_netreg_time_notify(struct ofono_netreg *netreg,
__ofono_nettime_info_received(modem, info);
}
-static void signal_strength_callback(const struct ofono_error *error,
- int strength, void *data)
-{
- struct ofono_netreg *netreg = data;
-
- if (error->type != OFONO_ERROR_TYPE_NO_ERROR) {
- DBG("Error during signal strength query");
- return;
- }
-
- ofono_netreg_strength_notify(netreg, strength);
-}
-
static void init_registration_status(const struct ofono_error *error,
int status, int lac, int ci, int tech,
void *data)
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] network: query signal strength when status changes to registered or roaming.
2010-12-03 15:00 [PATCH] network: query signal strength when status changes to registered or roaming Marit Henriksen
@ 2010-12-15 14:01 ` Marit Sofie Henriksen
2010-12-16 18:52 ` Gustavo F. Padovan
1 sibling, 0 replies; 3+ messages in thread
From: Marit Sofie Henriksen @ 2010-12-15 14:01 UTC (permalink / raw)
To: ofono
[-- Attachment #1: Type: text/plain, Size: 2765 bytes --]
2010/12/3 Marit Henriksen <maritsofie.henriksen8@gmail.com>
> From: Marit Henriksen <marit.henriksen@stericsson.com>
>
>
Hi. I was wondering if you have had the chance to look at this patch yet?
regards, Marit
> Signal strength is set to -1 whenever registration status changes
> and differs from registered or roaming. When registration status
> changes again to registered or roaming, the signal strength needs to
> be updated, so add query towards driver to get it.
> ---
> src/network.c | 29 ++++++++++++++++-------------
> 1 files changed, 16 insertions(+), 13 deletions(-)
>
> diff --git a/src/network.c b/src/network.c
> index d5b42a1..80fa83d 100644
> --- a/src/network.c
> +++ b/src/network.c
> @@ -1296,6 +1296,19 @@ emit:
> notify_status_watches(netreg);
> }
>
> +static void signal_strength_callback(const struct ofono_error *error,
> + int strength, void *data)
> +{
> + struct ofono_netreg *netreg = data;
> +
> + if (error->type != OFONO_ERROR_TYPE_NO_ERROR) {
> + DBG("Error during signal strength query");
> + return;
> + }
> +
> + ofono_netreg_strength_notify(netreg, strength);
> +}
> +
> void ofono_netreg_status_notify(struct ofono_netreg *netreg, int status,
> int lac, int ci, int tech)
> {
> @@ -1319,6 +1332,9 @@ void ofono_netreg_status_notify(struct ofono_netreg
> *netreg, int status,
> if (netreg->driver->current_operator)
> netreg->driver->current_operator(netreg,
> current_operator_callback, netreg);
> + if (netreg->driver->strength)
> + netreg->driver->strength(netreg,
> + signal_strength_callback, netreg);
> } else {
> struct ofono_error error;
>
> @@ -1345,19 +1361,6 @@ void ofono_netreg_time_notify(struct ofono_netreg
> *netreg,
> __ofono_nettime_info_received(modem, info);
> }
>
> -static void signal_strength_callback(const struct ofono_error *error,
> - int strength, void *data)
> -{
> - struct ofono_netreg *netreg = data;
> -
> - if (error->type != OFONO_ERROR_TYPE_NO_ERROR) {
> - DBG("Error during signal strength query");
> - return;
> - }
> -
> - ofono_netreg_strength_notify(netreg, strength);
> -}
> -
> static void init_registration_status(const struct ofono_error *error,
> int status, int lac, int ci, int
> tech,
> void *data)
> --
> 1.7.1
>
>
[-- Attachment #2: attachment.html --]
[-- Type: text/html, Size: 3450 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] network: query signal strength when status changes to registered or roaming.
2010-12-03 15:00 [PATCH] network: query signal strength when status changes to registered or roaming Marit Henriksen
2010-12-15 14:01 ` Marit Sofie Henriksen
@ 2010-12-16 18:52 ` Gustavo F. Padovan
1 sibling, 0 replies; 3+ messages in thread
From: Gustavo F. Padovan @ 2010-12-16 18:52 UTC (permalink / raw)
To: ofono
[-- Attachment #1: Type: text/plain, Size: 2548 bytes --]
Hi Marit,
Your commit subject is too big, you should not use more than 72 characters
there. Ideally you should not use more than 50, but up to 72 is still ok.
Leave the additional info to the commit message.
* Marit Henriksen <maritsofie.henriksen8@gmail.com> [2010-12-03 16:00:41 +0100]:
> From: Marit Henriksen <marit.henriksen@stericsson.com>
>
> Signal strength is set to -1 whenever registration status changes
> and differs from registered or roaming. When registration status
> changes again to registered or roaming, the signal strength needs to
> be updated, so add query towards driver to get it.
> ---
> src/network.c | 29 ++++++++++++++++-------------
> 1 files changed, 16 insertions(+), 13 deletions(-)
>
> diff --git a/src/network.c b/src/network.c
> index d5b42a1..80fa83d 100644
> --- a/src/network.c
> +++ b/src/network.c
> @@ -1296,6 +1296,19 @@ emit:
> notify_status_watches(netreg);
> }
>
> +static void signal_strength_callback(const struct ofono_error *error,
> + int strength, void *data)
> +{
> + struct ofono_netreg *netreg = data;
> +
> + if (error->type != OFONO_ERROR_TYPE_NO_ERROR) {
> + DBG("Error during signal strength query");
> + return;
> + }
> +
> + ofono_netreg_strength_notify(netreg, strength);
> +}
> +
> void ofono_netreg_status_notify(struct ofono_netreg *netreg, int status,
> int lac, int ci, int tech)
> {
> @@ -1319,6 +1332,9 @@ void ofono_netreg_status_notify(struct ofono_netreg *netreg, int status,
> if (netreg->driver->current_operator)
> netreg->driver->current_operator(netreg,
> current_operator_callback, netreg);
> + if (netreg->driver->strength)
> + netreg->driver->strength(netreg,
> + signal_strength_callback, netreg);
> } else {
> struct ofono_error error;
>
> @@ -1345,19 +1361,6 @@ void ofono_netreg_time_notify(struct ofono_netreg *netreg,
> __ofono_nettime_info_received(modem, info);
> }
>
> -static void signal_strength_callback(const struct ofono_error *error,
> - int strength, void *data)
> -{
> - struct ofono_netreg *netreg = data;
> -
> - if (error->type != OFONO_ERROR_TYPE_NO_ERROR) {
> - DBG("Error during signal strength query");
> - return;
> - }
> -
> - ofono_netreg_strength_notify(netreg, strength);
> -}
> -
> static void init_registration_status(const struct ofono_error *error,
> int status, int lac, int ci, int tech,
> void *data)
Otherwise patch looks good.
--
Gustavo F. Padovan
http://profusion.mobi
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-12-16 18:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-12-03 15:00 [PATCH] network: query signal strength when status changes to registered or roaming Marit Henriksen
2010-12-15 14:01 ` Marit Sofie Henriksen
2010-12-16 18:52 ` Gustavo F. Padovan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox