Re: [PATCH] Add CNAP support for isimodem

[Gustavo F. Padovan <padovan@profusion.mobi>]

[-- Attachment #1: Type: text/plain, Size: 2143 bytes --]

Hy Antoine,

Top posting is not allowed on this mailing list. Please stop using it.

* Antoine Reversat <a.reversat@gmail.com> [2011-02-25 11:33:49 -0500]:

> This one should be clean. Sorry it created a new email. I specified a
> message-id but it don't see it as a reply to my mail in gmail here.

Get yourself a proper mail client. Your message shows a reply of the previous
patch.

> 
> On Fri, Feb 25, 2011 at 11:28 AM, Antoine Reversat <a.reversat@gmail.com> wrote:
> > ---
> >  drivers/isimodem/voicecall.c |   50 +++++++++++++++++++++++++++++++++++++----
> >  src/voicecall.c              |    5 ++-
> >  2 files changed, 48 insertions(+), 7 deletions(-)
> >
> > diff --git a/drivers/isimodem/voicecall.c b/drivers/isimodem/voicecall.c
> > index 0a32f27..37b0eb3 100644
> > --- a/drivers/isimodem/voicecall.c
> > +++ b/drivers/isimodem/voicecall.c
> > @@ -56,8 +56,10 @@ struct isi_call {
> >        uint8_t cause;
> >        uint8_t addr_type;
> >        uint8_t presentation;
> > +       uint8_t name_presentation;
> >        uint8_t reason;
> >        char address[20];
> > +       char name[20];
> >        char addr_pad[4];
> >  };
> >
> > @@ -210,10 +212,13 @@ static void isi_call_any_address_sb_proc(struct isi_voicecall *ivc,
> >        uint8_t len;
> >        char *addr;
> >
> > -       if (!g_isi_sb_iter_get_byte(sb, &type, 2) ||
> > -                       !g_isi_sb_iter_get_byte(sb, &pres, 3) ||
> > -                       !g_isi_sb_iter_get_byte(sb, &len, 5) ||
> > -                       !g_isi_sb_iter_get_alpha_tag(sb, &addr, 2 * len, 6))
> > +       if (!g_isi_sb_iter_get_byte(sb, &type, 2))
> > +               return;
> > +       if (!g_isi_sb_iter_get_byte(sb, &pres, 3))
> > +               return;
> > +       if (!g_isi_sb_iter_get_byte(sb, &len, 5))
> > +               return;
> > +       if (!g_isi_sb_iter_get_alpha_tag(sb, &addr, 2 * len, 6))

A separate patch for this change.

-- 
Gustavo F. Padovan
http://profusion.mobi