From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 1/2] Clean up isi_call_any_address_sb_proc
Date: Fri, 25 Feb 2011 12:43:35 -0600 [thread overview]
Message-ID: <4D67F857.3070306@gmail.com> (raw)
In-Reply-To: <1298653824-25127-1-git-send-email-a.reversat@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1121 bytes --]
Hi Antoine,
On 02/25/2011 11:10 AM, Antoine Reversat wrote:
> ---
> drivers/isimodem/voicecall.c | 11 +++++++----
> 1 files changed, 7 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/isimodem/voicecall.c b/drivers/isimodem/voicecall.c
> index 0a32f27..0ad4dfb 100644
> --- a/drivers/isimodem/voicecall.c
> +++ b/drivers/isimodem/voicecall.c
> @@ -210,10 +210,13 @@ static void isi_call_any_address_sb_proc(struct isi_voicecall *ivc,
> uint8_t len;
> char *addr;
>
> - if (!g_isi_sb_iter_get_byte(sb, &type, 2) ||
> - !g_isi_sb_iter_get_byte(sb, &pres, 3) ||
> - !g_isi_sb_iter_get_byte(sb, &len, 5) ||
> - !g_isi_sb_iter_get_alpha_tag(sb, &addr, 2 * len, 6))
> + if (!g_isi_sb_iter_get_byte(sb, &type, 2))
> + return;
> + if (!g_isi_sb_iter_get_byte(sb, &pres, 3))
> + return;
> + if (!g_isi_sb_iter_get_byte(sb, &len, 5))
> + return;
> + if (!g_isi_sb_iter_get_alpha_tag(sb, &addr, 2 * len, 6))
> return;
This is indeed the preferred structure, however please note
doc/coding-style.txt rule M1.
>
> call->addr_type = type | 0x80;
Regards,
-Denis
next prev parent reply other threads:[~2011-02-25 18:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-22 19:31 [PATCH] Add CNAP support (callerid name presentation) to isimodem Antoine Reversat
2011-02-22 21:22 ` Gustavo F. Padovan
2011-02-22 21:34 ` Antoine Reversat
2011-02-25 16:28 ` [PATCH] Add CNAP support for isimodem Antoine Reversat
2011-02-25 16:33 ` Antoine Reversat
2011-02-25 16:34 ` Antoine Reversat
2011-02-25 16:53 ` Gustavo F. Padovan
2011-02-25 17:04 ` Antoine Reversat
2011-02-25 17:10 ` [PATCH 1/2] Clean up isi_call_any_address_sb_proc Antoine Reversat
2011-02-25 18:43 ` Denis Kenzior [this message]
2011-02-25 17:10 ` [PATCH 2/2] Add CNAP support for isimodem Antoine Reversat
2011-02-25 18:45 ` Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D67F857.3070306@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox