From: Vinicius Costa Gomes <vinicius.gomes@openbossa.org>
To: ofono@ofono.org
Subject: Re: AW: [PATCH 05/10] hfp_hf_bluez5: Handle NewConnection from BlueZ
Date: Wed, 23 Jan 2013 13:39:52 -0300 [thread overview]
Message-ID: <20130123163951.GC6545@samus> (raw)
In-Reply-To: <50FFF896.4080800@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 979 bytes --]
Hi,
On 08:49 Wed 23 Jan, Denis Kenzior wrote:
> Hi Andreas,
>
> <snip>
>
> >I assume returning NULL is ok here if nothing went wrong?
> >I'm not familiar with plain dbus API, just using glib gdbus, there I would expect to create an answer to the call.
>
> The NewConnection method is marked as 'ASYNC' in the method table
> (see profile_methods). In our gdbus library, returning NULL here
> means that the method return is deferred until a later time. E.g.
> when we try to establish a SLC connection and fail / succeed.
>
> In this patch it is left kind of hanging out there and you would
> need to peek at patch 10 to really know what happens to it.
> Confusing, I know ;)
Do you think it is worth adding a comment in the code, that would be later
removed?
>
> Regards,
> -Denis
> _______________________________________________
> ofono mailing list
> ofono(a)ofono.org
> http://lists.ofono.org/listinfo/ofono
Cheers,
--
Vinicius
next prev parent reply other threads:[~2013-01-23 16:39 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-22 21:43 [PATCH 00/10] HFP Service Level Connection establishment Vinicius Costa Gomes
2013-01-22 21:43 ` [PATCH 01/10] hfp_hf_bluez5: Initial GDBusClient for BlueZ Vinicius Costa Gomes
2013-01-23 4:30 ` Denis Kenzior
2013-01-23 14:16 ` Vinicius Costa Gomes
2013-01-22 21:43 ` [PATCH 02/10] hfp_hf_bluez5: Add GDBusProxy for Bluetooth devices Vinicius Costa Gomes
2013-01-22 21:43 ` [PATCH 03/10] hfp_hf_bluez5: Register modem for HFP AG capable devices Vinicius Costa Gomes
2013-01-23 4:59 ` Denis Kenzior
2013-01-23 14:22 ` Vinicius Costa Gomes
2013-01-22 21:43 ` [PATCH 04/10] hfp_hf_bluez5: Keep track of changes of devices Aliases Vinicius Costa Gomes
2013-01-22 21:43 ` [PATCH 05/10] hfp_hf_bluez5: Handle NewConnection from BlueZ Vinicius Costa Gomes
2013-01-23 4:54 ` Denis Kenzior
2013-01-23 12:03 ` AW: " Kling, Andreas
2013-01-23 14:49 ` Denis Kenzior
2013-01-23 16:39 ` Vinicius Costa Gomes [this message]
2013-01-22 21:43 ` [PATCH 06/10] hfpmodem: Add dynamic hfp_slc_info allocation Vinicius Costa Gomes
2013-01-22 21:43 ` [PATCH 07/10] hfpmodem: Implement hfp_slc_info_free Vinicius Costa Gomes
2013-01-22 21:43 ` [PATCH 08/10] hfp_hf_bluez4: Use hfp_slc_info_free() Vinicius Costa Gomes
2013-01-22 21:43 ` [PATCH 09/10] phonesim: " Vinicius Costa Gomes
2013-01-22 21:43 ` [PATCH 10/10] hfp_hf_bluez5: Add SLC establishment procedure Vinicius Costa Gomes
2013-01-23 5:26 ` Denis Kenzior
2013-01-23 18:27 ` [PATCH v1 00/10] HFP Service Level Connection establishment Vinicius Costa Gomes
2013-01-23 18:27 ` [PATCH v1 01/10] hfp_hf_bluez5: Initial GDBusClient for BlueZ Vinicius Costa Gomes
2013-01-23 20:31 ` Denis Kenzior
2013-01-23 18:27 ` [PATCH v1 02/10] hfp_hf_bluez5: Add GDBusProxy for Bluetooth devices Vinicius Costa Gomes
2013-01-23 20:31 ` Denis Kenzior
2013-01-23 18:27 ` [PATCH v1 03/10] hfp_hf_bluez5: Register modem for HFP AG capable devices Vinicius Costa Gomes
2013-01-23 20:32 ` Denis Kenzior
2013-01-23 18:27 ` [PATCH v1 04/10] hfp_hf_bluez5: Keep track of changes of devices Aliases Vinicius Costa Gomes
2013-01-23 20:32 ` Denis Kenzior
2013-01-23 18:27 ` [PATCH v1 05/10] hfp_hf_bluez5: Handle NewConnection from BlueZ Vinicius Costa Gomes
2013-01-23 20:32 ` Denis Kenzior
2013-01-23 18:27 ` [PATCH v1 06/10] hfpmodem: Add dynamic hfp_slc_info allocation Vinicius Costa Gomes
2013-01-23 20:34 ` Denis Kenzior
2013-01-23 23:04 ` Vinicius Costa Gomes
2013-01-23 18:27 ` [PATCH v1 07/10] hfpmodem: Implement hfp_slc_info_free() Vinicius Costa Gomes
2013-01-23 18:27 ` [PATCH v1 08/10] hfp_hf_bluez4: Use hfp_slc_info_free() Vinicius Costa Gomes
2013-01-23 18:28 ` [PATCH v1 09/10] phonesim: " Vinicius Costa Gomes
2013-01-23 18:28 ` [PATCH v1 10/10] hfp_hf_bluez5: Add SLC establishment procedure Vinicius Costa Gomes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130123163951.GC6545@samus \
--to=vinicius.gomes@openbossa.org \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox