From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH v1 06/10] hfpmodem: Add dynamic hfp_slc_info allocation
Date: Wed, 23 Jan 2013 14:34:00 -0600 [thread overview]
Message-ID: <51004938.30503@gmail.com> (raw)
In-Reply-To: <1358965681-7420-7-git-send-email-vinicius.gomes@openbossa.org>
[-- Attachment #1: Type: text/plain, Size: 697 bytes --]
Hi Vinicius,
> diff --git a/plugins/phonesim.c b/plugins/phonesim.c
> index 26f96d0..9210e02 100644
> --- a/plugins/phonesim.c
> +++ b/plugins/phonesim.c
> @@ -929,8 +929,8 @@ static int localhfp_enable(struct ofono_modem *modem)
>
> g_at_chat_set_disconnect_function(chat, slc_failed, modem);
>
> - hfp_slc_info_init(info, HFP_VERSION_LATEST);
> - info->chat = chat;
> + info = hfp_slc_info_init(chat, HFP_VERSION_LATEST);
> + g_at_chat_unref(chat);
> hfp_slc_establish(info, slc_established, slc_failed, modem);
>
> return -EINPROGRESS;
This part makes no sense. I refer you to localhfp_probe() function.
Are you testing any of your changes?
Regards,
-Denis
next prev parent reply other threads:[~2013-01-23 20:34 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-22 21:43 [PATCH 00/10] HFP Service Level Connection establishment Vinicius Costa Gomes
2013-01-22 21:43 ` [PATCH 01/10] hfp_hf_bluez5: Initial GDBusClient for BlueZ Vinicius Costa Gomes
2013-01-23 4:30 ` Denis Kenzior
2013-01-23 14:16 ` Vinicius Costa Gomes
2013-01-22 21:43 ` [PATCH 02/10] hfp_hf_bluez5: Add GDBusProxy for Bluetooth devices Vinicius Costa Gomes
2013-01-22 21:43 ` [PATCH 03/10] hfp_hf_bluez5: Register modem for HFP AG capable devices Vinicius Costa Gomes
2013-01-23 4:59 ` Denis Kenzior
2013-01-23 14:22 ` Vinicius Costa Gomes
2013-01-22 21:43 ` [PATCH 04/10] hfp_hf_bluez5: Keep track of changes of devices Aliases Vinicius Costa Gomes
2013-01-22 21:43 ` [PATCH 05/10] hfp_hf_bluez5: Handle NewConnection from BlueZ Vinicius Costa Gomes
2013-01-23 4:54 ` Denis Kenzior
2013-01-23 12:03 ` AW: " Kling, Andreas
2013-01-23 14:49 ` Denis Kenzior
2013-01-23 16:39 ` Vinicius Costa Gomes
2013-01-22 21:43 ` [PATCH 06/10] hfpmodem: Add dynamic hfp_slc_info allocation Vinicius Costa Gomes
2013-01-22 21:43 ` [PATCH 07/10] hfpmodem: Implement hfp_slc_info_free Vinicius Costa Gomes
2013-01-22 21:43 ` [PATCH 08/10] hfp_hf_bluez4: Use hfp_slc_info_free() Vinicius Costa Gomes
2013-01-22 21:43 ` [PATCH 09/10] phonesim: " Vinicius Costa Gomes
2013-01-22 21:43 ` [PATCH 10/10] hfp_hf_bluez5: Add SLC establishment procedure Vinicius Costa Gomes
2013-01-23 5:26 ` Denis Kenzior
2013-01-23 18:27 ` [PATCH v1 00/10] HFP Service Level Connection establishment Vinicius Costa Gomes
2013-01-23 18:27 ` [PATCH v1 01/10] hfp_hf_bluez5: Initial GDBusClient for BlueZ Vinicius Costa Gomes
2013-01-23 20:31 ` Denis Kenzior
2013-01-23 18:27 ` [PATCH v1 02/10] hfp_hf_bluez5: Add GDBusProxy for Bluetooth devices Vinicius Costa Gomes
2013-01-23 20:31 ` Denis Kenzior
2013-01-23 18:27 ` [PATCH v1 03/10] hfp_hf_bluez5: Register modem for HFP AG capable devices Vinicius Costa Gomes
2013-01-23 20:32 ` Denis Kenzior
2013-01-23 18:27 ` [PATCH v1 04/10] hfp_hf_bluez5: Keep track of changes of devices Aliases Vinicius Costa Gomes
2013-01-23 20:32 ` Denis Kenzior
2013-01-23 18:27 ` [PATCH v1 05/10] hfp_hf_bluez5: Handle NewConnection from BlueZ Vinicius Costa Gomes
2013-01-23 20:32 ` Denis Kenzior
2013-01-23 18:27 ` [PATCH v1 06/10] hfpmodem: Add dynamic hfp_slc_info allocation Vinicius Costa Gomes
2013-01-23 20:34 ` Denis Kenzior [this message]
2013-01-23 23:04 ` Vinicius Costa Gomes
2013-01-23 18:27 ` [PATCH v1 07/10] hfpmodem: Implement hfp_slc_info_free() Vinicius Costa Gomes
2013-01-23 18:27 ` [PATCH v1 08/10] hfp_hf_bluez4: Use hfp_slc_info_free() Vinicius Costa Gomes
2013-01-23 18:28 ` [PATCH v1 09/10] phonesim: " Vinicius Costa Gomes
2013-01-23 18:28 ` [PATCH v1 10/10] hfp_hf_bluez5: Add SLC establishment procedure Vinicius Costa Gomes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51004938.30503@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox