From: Philip Paeps <philip@paeps.cx>
To: ofono@ofono.org
Subject: Re: [PATCH 1/3] gatchat: implement PAP authentication
Date: Thu, 19 Jun 2014 11:41:15 +0200 [thread overview]
Message-ID: <20140619094115.GC33006@rincewind.trouble.is> (raw)
In-Reply-To: <53A210C0.9020501@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 931 bytes --]
On 2014-06-18 17:20:48 (-0500), Denis Kenzior <denkenz@gmail.com> wrote:
> On 06/17/2014 04:57 PM, Philip Paeps wrote:
> > + /*
> > + * RFC 1334 2.2.1:
> > + * The Identifier field MUST be changed each time an
> > + * Authenticate-Request packet is issued.
> > + */
> > + authreq = (struct pap_header *)&pap->authreq->info;
> > + authreq->identifier = g_random_int() % G_MAXUINT8;
>
> Is this sufficient to fulfill the requirement stated in the comment? It
> would be highly unlikely, but the identifier might still be repeated,
> no? Would it be easier to simply use a counter?
This should be sufficient. The RFC says it must be changed each time we
send a packet. It doesn't say anything about never repeating values.
On the other hand, both CMU pppd and BSD ppp use a counter. I have
changed this in my updated patch.
Philip
--
Philip Paeps
Senior Reality Engineer
Ministry of Information
next prev parent reply other threads:[~2014-06-19 9:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-17 21:57 [PATCH] Add support for PAP authentication Philip Paeps
2014-06-17 21:57 ` [PATCH 1/3] gatchat: implement " Philip Paeps
2014-06-18 22:20 ` Denis Kenzior
2014-06-19 8:29 ` Philip Paeps
2014-06-19 9:41 ` Philip Paeps [this message]
2014-06-17 21:57 ` [PATCH 2/3] gprs: make PPP authentication method configurable Philip Paeps
2014-06-18 22:27 ` Denis Kenzior
2014-06-17 21:57 ` [PATCH 3/3] mbpi: add authentication methods to provisioning Philip Paeps
2014-06-18 22:33 ` Denis Kenzior
2014-06-19 8:34 ` Philip Paeps
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140619094115.GC33006@rincewind.trouble.is \
--to=philip@paeps.cx \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox