From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 2/3] gprs: make PPP authentication method configurable
Date: Wed, 18 Jun 2014 17:27:36 -0500 [thread overview]
Message-ID: <53A21258.2080700@gmail.com> (raw)
In-Reply-To: <1403042279-20598-3-git-send-email-philip@paeps.cx>
[-- Attachment #1: Type: text/plain, Size: 1337 bytes --]
Hi Philip,
On 06/17/2014 04:57 PM, Philip Paeps wrote:
> Add a new "AuthMethod" property to select between "pap" and "chap" PPP
> authentication, defaulting to "chap" (i.e.: previous behaviour).
>
> Signed-off-by: Philip Paeps <philip@paeps.cx>
No signed-off-by please...
> ---
> doc/connman-api.txt | 4 ++
> drivers/atmodem/gprs-context.c | 14 +++++++
> include/gprs-context.h | 6 +++
> src/gprs.c | 81 ++++++++++++++++++++++++++++++++++++++++
Please break this up into separate patches. See HACKING, 'Submitting
Patches' section.
> 4 files changed, 105 insertions(+)
>
> diff --git a/doc/connman-api.txt b/doc/connman-api.txt
> index 2227ab8..6347a8c 100644
> --- a/doc/connman-api.txt
> +++ b/doc/connman-api.txt
> @@ -180,6 +180,10 @@ Properties boolean Active [readwrite]
> "wap" - Used by WAP related services
> "ims" - Used by IMS related services
>
> + string AuthMethod [readwrite]
> + Holds the PPP authentication method to use. Valid
> + values are "pap" and "chap". Defaults to "chap".
> +
Please name this AuthenticationType or AuthenticationMethod.
> string Username [readwrite]
>
> Holds the username to be used for authentication
Otherwise, the rest looks fine to me
Regards,
-Denis
next prev parent reply other threads:[~2014-06-18 22:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-17 21:57 [PATCH] Add support for PAP authentication Philip Paeps
2014-06-17 21:57 ` [PATCH 1/3] gatchat: implement " Philip Paeps
2014-06-18 22:20 ` Denis Kenzior
2014-06-19 8:29 ` Philip Paeps
2014-06-19 9:41 ` Philip Paeps
2014-06-17 21:57 ` [PATCH 2/3] gprs: make PPP authentication method configurable Philip Paeps
2014-06-18 22:27 ` Denis Kenzior [this message]
2014-06-17 21:57 ` [PATCH 3/3] mbpi: add authentication methods to provisioning Philip Paeps
2014-06-18 22:33 ` Denis Kenzior
2014-06-19 8:34 ` Philip Paeps
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53A21258.2080700@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox