From: =?unknown-8bit?q?Andr=C3=A9?= Draszik <git@andred.net>
To: ofono@ofono.org
Subject: [PATCH v2] plugins: telit: send AT&C0 on both channels
Date: Tue, 07 Feb 2017 11:26:50 +0000 [thread overview]
Message-ID: <20170207112650.10222-1-git@andred.net> (raw)
In-Reply-To: <20170207085757.4712-1-git@andred.net>
[-- Attachment #1: Type: text/plain, Size: 962 bytes --]
At least firmware version 12.00.405 on the UE910-EUR otherwise
closes the AT command port whenever the PPP connection is
dropped, and we'd be left in a funny state.
---
Changes in v2: Commit message updated
---
plugins/telit.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/plugins/telit.c b/plugins/telit.c
index 742e06c0..0ae16408 100644
--- a/plugins/telit.c
+++ b/plugins/telit.c
@@ -249,9 +249,10 @@ static void cfun_enable_cb(gboolean ok, GAtResult *result, gpointer user_data)
/*
* Switch data carrier detect signal off.
* When the DCD is disabled the modem does not hangup anymore
- * after the data connection.
+ * after the data connection. We need to do that on both channels.
*/
g_at_chat_send(data->chat, "AT&C0", NULL, NULL, NULL, NULL);
+ g_at_chat_send(data->modem, "AT&C0", NULL, NULL, NULL, NULL);
data->have_sim = FALSE;
data->sms_phonebook_added = FALSE;
--
2.11.0
next prev parent reply other threads:[~2017-02-07 11:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-07 8:57 [PATCH] plugins: telit: send AT&C0 on both channels =?unknown-8bit?q?Andr=C3=A9?= Draszik
2017-02-07 11:26 ` =?unknown-8bit?q?Andr=C3=A9?= Draszik [this message]
2017-02-07 17:08 ` [PATCH v2] " Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170207112650.10222-1-git@andred.net \
--to=git@andred.net \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox