[PATCH] plugins: telit: send AT&C0 on both channels

[PATCH] plugins: telit: send AT&C0 on both channels

[=?unknown-8bit?q?Andr=C3=A9?= Draszik]

[-- Attachment #1: Type: text/plain, Size: 874 bytes --]

At least firmware version 12.00.405 on the UE910-EUR otherwise
closes the modem channel, and we'd be left in a funny state.
---
 plugins/telit.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/plugins/telit.c b/plugins/telit.c
index 742e06c0..0ae16408 100644
--- a/plugins/telit.c
+++ b/plugins/telit.c
@@ -249,9 +249,10 @@ static void cfun_enable_cb(gboolean ok, GAtResult *result, gpointer user_data)
 	/*
 	 * Switch data carrier detect signal off.
 	 * When the DCD is disabled the modem does not hangup anymore
-	 * after the data connection.
+	 * after the data connection. We need to do that on both channels.
 	 */
 	g_at_chat_send(data->chat, "AT&C0", NULL, NULL, NULL, NULL);
+	g_at_chat_send(data->modem, "AT&C0", NULL, NULL, NULL, NULL);
 
 	data->have_sim = FALSE;
 	data->sms_phonebook_added = FALSE;
-- 
2.11.0

[PATCH v2] plugins: telit: send AT&C0 on both channels

[=?unknown-8bit?q?Andr=C3=A9?= Draszik]

[-- Attachment #1: Type: text/plain, Size: 962 bytes --]

At least firmware version 12.00.405 on the UE910-EUR otherwise
closes the AT command port whenever the PPP connection is
dropped, and we'd be left in a funny state.

---
Changes in v2: Commit message updated
---
 plugins/telit.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/plugins/telit.c b/plugins/telit.c
index 742e06c0..0ae16408 100644
--- a/plugins/telit.c
+++ b/plugins/telit.c
@@ -249,9 +249,10 @@ static void cfun_enable_cb(gboolean ok, GAtResult *result, gpointer user_data)
 	/*
 	 * Switch data carrier detect signal off.
 	 * When the DCD is disabled the modem does not hangup anymore
-	 * after the data connection.
+	 * after the data connection. We need to do that on both channels.
 	 */
 	g_at_chat_send(data->chat, "AT&C0", NULL, NULL, NULL, NULL);
+	g_at_chat_send(data->modem, "AT&C0", NULL, NULL, NULL, NULL);
 
 	data->have_sim = FALSE;
 	data->sms_phonebook_added = FALSE;
-- 
2.11.0

Re: [PATCH v2] plugins: telit: send AT&C0 on both channels

[Denis Kenzior]

[-- Attachment #1: Type: text/plain, Size: 417 bytes --]

Hi André,

On 02/07/2017 05:26 AM, André Draszik wrote:
> At least firmware version 12.00.405 on the UE910-EUR otherwise
> closes the AT command port whenever the PPP connection is
> dropped, and we'd be left in a funny state.
>
> ---
> Changes in v2: Commit message updated
> ---
>  plugins/telit.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>

Applied, thanks.

Regards,
-Denis