Re: [PATCH 1/1] udev: add serial_info struct to modem

[Clayton Craft <clayton@craftyguy.net>]

[-- Attachment #1: Type: text/plain, Size: 2595 bytes --]

Hi Jonas,

This looks MUCH better!! Just to re-cap, it took the application of
all three of the patches you sent over to get this to finally come up.


ofonod[1800]: plugins/nokia-gpio.c:phonet_status_cb() Link phonet0 (2) is down
ofonod[1800]: plugins/nokia-gpio.c:gpio_power_state_machine() (POWER_EVENT_PHONET_LINK_DOWN) @ state POWER_STATE_NONE
ofonod[1800]: plugins/nokia-gpio.c:gpio_power_set_state() (POWER_STATE_OFF) at (POWER_STATE_NONE)
ofonod[1800]: plugins/nokia-gpio.c:gpio_finish_modem_power_off()
ofonod[1800]: plugins/nokia-gpio.c:gpio_write() ("cmt_apeslpx", "inactive")
ofonod[1800]: plugins/nokia-gpio.c:gpio_write() ("cmt_rst_rq", "inactive")
ofonod[1800]: plugins/nokia-gpio.c:gpio_write() ("cmt_en", "inactive")
ofonod[1800]: plugins/nokia-gpio.c:gpio_write() ("cmt_rst", "inactive")
ofonod[1800]: plugins/nokia-gpio.c:gpio_write() ("cmt_rst", "active")
ofonod[1800]: plugins/n900.c:n900_power_cb() power state POWER_STATE_OFF
ofonod[1800]: plugins/n900.c:n900_enable() modem=0x617ad0 with 0x617cd0



localhost:/home/user/ofono# python2 test/list-modems
[ /n900_2 ]
    Features = sim
    Emergency = 0
    Powered = 1
    Lockdown = 0
    Interfaces = org.ofono.SimManager org.ofono.VoiceCallManager org.ofono.AudioSettings
    Online = 0
    Model = Nokia N900
    Revision = V ICPR82_10w08
25-02-10
RX-51
(c) Nokia
    Type = hardware
    Serial = 356938037199412
    Manufacturer = Nokia
    [ org.ofono.SimManager ]
        Present = 0
    [ org.ofono.VoiceCallManager ]
        EmergencyNumbers = 08 000 999 110 112 911 118 119
    [ org.ofono.AudioSettings ]
        Active = 0

Going to test some of the more 'advanced' features now :)

-Clayton


On Sat, Sep 09, 2017 at 11:05:19AM +0200, Jonas Bonn wrote:
>---
>Hi Clayton,
>
>Sorry, I messed up the earlier patch.  It should be like this, I think.
>
>/Jonas
>
> plugins/udevng.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/plugins/udevng.c b/plugins/udevng.c
>index 5767259..a4b99aa 100644
>--- a/plugins/udevng.c
>+++ b/plugins/udevng.c
>@@ -1355,7 +1355,7 @@ static void add_serial_device(struct udev_device *dev)
> 	info->subsystem = g_strdup(subsystem);
> 	info->dev = udev_device_ref(dev);
>
>-	modem->devices = g_slist_append(modem->devices, info);
>+	modem->serial = info;
> }
>
> static void add_device(const char *syspath, const char *devname,
>-- 
>2.9.3
>
>_______________________________________________
>ofono mailing list
>ofono(a)ofono.org
>https://lists.ofono.org/mailman/listinfo/ofono