Open Source Telephony
 help / color / mirror / Atom feed
From: richard.rojfors@gmail.com
To: ofono@ofono.org
Subject: [PATCH v2 2/3] Revert "gprs: set driver_attached when activating automatic contexts"
Date: Tue, 20 Aug 2019 17:56:51 +0200	[thread overview]
Message-ID: <20190820155652.8598-2-richard.rojfors@gmail.com> (raw)
In-Reply-To: <20190820155652.8598-1-richard.rojfors@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 816 bytes --]

From: Richard Röjfors <richard@puffinpack.se>

This reverts commit 0167c3339ca8f17a653592af995f439d24405de8.

Since gprs_attached_update now takes LTE in account this
should be reverted. This was actually a bad solution since
in case LTE was lost, and we should fall back on GPRS we
have flagged the driver to already being attached, which is not...
---
 src/gprs.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/gprs.c b/src/gprs.c
index 5829a577..bd9b3680 100644
--- a/src/gprs.c
+++ b/src/gprs.c
@@ -940,7 +940,6 @@ static void pri_read_settings_callback(const struct ofono_error *error,
 
 	gprs->flags &= ~GPRS_FLAG_ATTACHING;
 
-	gprs->driver_attached = TRUE;
 	gprs_set_attached_property(gprs, TRUE);
 
 	ofono_dbus_signal_property_changed(conn, pri_ctx->path,
-- 
2.20.1


  reply	other threads:[~2019-08-20 15:56 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-20 15:56 [PATCH v2 1/3] gprs: Check for LTE in gprs_attached_update richard.rojfors
2019-08-20 15:56 ` richard.rojfors [this message]
2019-08-20 15:56 ` [PATCH v2 3/3] Revert "gprs: _cid_activated is an 'attaching' state" richard.rojfors
2019-08-21  6:01   ` Jonas Bonn
2019-08-21 15:55     ` Richard =?unknown-8bit?q?R=C3=B6jfors?=
2019-08-21 18:30     ` Denis Kenzior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190820155652.8598-2-richard.rojfors@gmail.com \
    --to=richard.rojfors@gmail.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox