From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH v2 3/3] Revert "gprs: _cid_activated is an 'attaching' state"
Date: Wed, 21 Aug 2019 13:30:37 -0500 [thread overview]
Message-ID: <518d2bb9-02fa-d794-5dff-9efd09abcb18@gmail.com> (raw)
In-Reply-To: <4a96c48e-91aa-0948-0dbc-d0fe8a7d3310@norrbonn.se>
[-- Attachment #1: Type: text/plain, Size: 991 bytes --]
Hi Richard, Jonas,
On 8/21/19 1:01 AM, Jonas Bonn wrote:
> Hi Richard,
>
> On 20/08/2019 17:56, richard.rojfors(a)gmail.com wrote:
>> From: Richard Röjfors <richard@puffinpack.se>
>>
>> This reverts commit 1fd419e5b4b3a87673f8e0219edb0f3ed9fca774.
>
> This patch is fine and certainly necessary in the context of this
> series. Posting it as a 'revert', however, is a bit unsavoury.
>
> A reverted patch implies that it was somehow wrong or inappropriate.
> That's not the case here. This code has become superfluous in the face
> of other changes that have been made in the tree.
>
> Just squash these two revert patches into one "forward looking" patch.
> The fact that the change effectively constitutes a 'revert' is moot.
>
So what I ended up doing was to squash patch 2 & 3 and reword the
description a bit, dropping the 'revert' heading per your wishes. Let
me know if you're fine with that.
Otherwise, all 3 applied.
Regards,
-Denis
prev parent reply other threads:[~2019-08-21 18:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-20 15:56 [PATCH v2 1/3] gprs: Check for LTE in gprs_attached_update richard.rojfors
2019-08-20 15:56 ` [PATCH v2 2/3] Revert "gprs: set driver_attached when activating automatic contexts" richard.rojfors
2019-08-20 15:56 ` [PATCH v2 3/3] Revert "gprs: _cid_activated is an 'attaching' state" richard.rojfors
2019-08-21 6:01 ` Jonas Bonn
2019-08-21 15:55 ` Richard =?unknown-8bit?q?R=C3=B6jfors?=
2019-08-21 18:30 ` Denis Kenzior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=518d2bb9-02fa-d794-5dff-9efd09abcb18@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox