Open Source Telephony
 help / color / mirror / Atom feed
From: Denis Kenzior <denkenz@gmail.com>
To: Adam Pigg <adam@piggz.co.uk>, ofono@lists.linux.dev
Subject: Re: [PATCH 1/4] [qmimodem][voicecall] Implement call dialing
Date: Mon, 25 Mar 2024 18:05:23 -0500	[thread overview]
Message-ID: <3c148086-1baa-4a72-83b9-c3d0fe0a8b5a@gmail.com> (raw)
In-Reply-To: <20240325221742.5931-1-adam@piggz.co.uk>

Hi Adam,

On 3/25/24 17:16, Adam Pigg wrote:
> Add voicecall dialling to the qmimodem driver
> Includes required infratructure and setup of the QMI services
> ---
>   drivers/qmimodem/voice.h     |  51 ++++
>   drivers/qmimodem/voicecall.c | 506 ++++++++++++++++++++++++++++++++++-
>   2 files changed, 555 insertions(+), 2 deletions(-)
> 

Hmm, have you rebased on top of git HEAD?

CI seems unable to apply this series

Run git-pw series apply 838112
Failed to apply patch:
Applying: Implement call dialing
error: sha1 information is lacking or useless (drivers/qmimodem/voicecall.c).
error: could not build fake ancestor
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Implement call dialing
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Also, I can't do it manually on my end due to:

[denkenz@archdev ofono]$ git pw series apply 838112
Failed to apply patch:
Applying: Implement call dialing
.git/rebase-apply/patch:92: new blank line at EOF.
+
.git/rebase-apply/patch:652: new blank line at EOF.
+
error: 2 lines add whitespace errors.

Regards,
-Denis

  parent reply	other threads:[~2024-03-25 23:05 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-25 22:16 [PATCH 1/4] [qmimodem][voicecall] Implement call dialing Adam Pigg
2024-03-25 22:17 ` [PATCH 2/4] [qmimodem][voicecall] Implement call answer Adam Pigg
2024-03-25 22:17 ` [PATCH 3/4] [qmimodem][voicecall] Implement active call hangup Adam Pigg
2024-03-25 22:17 ` [PATCH 4/4] [qmimodem][voicecall] Implement DTMF tones Adam Pigg
2024-03-25 23:05 ` Denis Kenzior [this message]
2024-03-25 23:32   ` [PATCH 1/4] [qmimodem][voicecall] Implement call dialing piggz1
  -- strict thread matches above, loose matches on Subject: below --
2024-04-21 19:49 [PATCH 1/4] qmimodem: voicecall: " Adam Pigg
2024-04-21 20:06 ` Adam Pigg
2024-04-22 21:05 ` Denis Kenzior
2024-04-22 21:10 ` patchwork-bot+ofono

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3c148086-1baa-4a72-83b9-c3d0fe0a8b5a@gmail.com \
    --to=denkenz@gmail.com \
    --cc=adam@piggz.co.uk \
    --cc=ofono@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox