Re: [PATCH 1/4] qmimodem: voicecall: Implement call dialing

[Denis Kenzior <denkenz@gmail.com>]

On 4/21/24 14:49, Adam Pigg wrote:
> Add voicecall dialling to the qmimodem driver
> Includes required infrastructure and setup of the QMI services
> 
> Call State Handling
> ===================
> On initialisation, register the all_call_status_ind callback to be
> called for QMI_VOICE_IND_ALL_STATUS.  This will handle notification of
> call status to the rest of the system
> 
> Dial Handling
> =============
> The dial function sets up the parameters for the QMI_VOICE_DIAL_CALL
> service.  The parameters are the number to be called and the call type,
> which is currently hard coded to be QMI_VOICE_CALL_TYPE_VOICE.  The
> dial_cb callback will then be called and will receive the call-id.
> 
> ---
> Changes in V4
> -merged qmi_voice_call_status and all_call_status_ind
> -several minor structure/formate changes
> 
> Changes in V5
> -renames ofono_call_compare_by_id to ofono_call_match_by_id
> -updated new_entry pointer to fix use-after-free in
> ofono_call_list_notify
> -Renamed several constants
> -in all_call_status_ind removed error label/gotos after restructuring
> -When creating the call list, ensure an upper bound of 16
> -Fix out-of-mound-read on remote number due to QMI string not being null
> terminated
> ---
> ---
>   drivers/qmimodem/voice.h     |  17 ++
>   drivers/qmimodem/voicecall.c | 426 ++++++++++++++++++++++++++++++++++-
>   2 files changed, 442 insertions(+), 1 deletion(-)
> 

I had the following when this patch was applied:

[denkenz@archdev ofono]$ make
make --no-print-directory all-am
   CC       drivers/qmimodem/voicecall.o
vdrivers/qmimodem/voicecall.c: In function ‘all_call_status_ind’:
drivers/qmimodem/voicecall.c:348:9: error: ISO C90 forbids mixed declarations 
and code [-Werror=declaration-after-statement]
   348 |         struct l_queue *calls = l_queue_new();
       |         ^~~~~~
drivers/qmimodem/voicecall.c:364:17: error: ISO C90 forbids mixed declarations 
and code [-Werror=declaration-after-statement]
   364 |                 char *tmp = l_strndup(remote_party->number, number_size);
       |                 ^~~~
icc1: all warnings being treated as errors

I fixed this up manually to declare calls & tmp in the variable block to avoid 
ISO C90 warning.

Patches 1-3 applied, thanks.

Regards,
-Denis