Re: [PATCH 4/4] qmimodem: voicecall: Implement DTMF tones

[Denis Kenzior <denkenz@gmail.com>]

Hi Adam,

On 4/23/24 05:10, Adam Pigg wrote:
> Hi Dennis
> 
> Thanks for the thorough review and merging the others....
> 

And thanks for doing all the hard work :)

<snip>

>>> +
>>> +	CALLBACK_WITH_SUCCESS(vd->send_dtmf_cb, vd->send_dtmf_data);
>>
>> This calls back into oFono core unconditionally.  Doesn't this imply that
>> you're handling only a single DTMF character?
>>
> Currently, ive only been able to test using single character invocations,
> using the num-pad on the phone app.  Do you have any suggestions on how to
> trigger multiple characters?

Take a look at doc/voicecallmanager-api.txt.  The SendTones() method takes a 
string of tones, so there can be multiple tones per request.  If your phone 
dialer UI does not support sending multiple tones, then the easiest way is to 
use a command line utility like 'dbus-send' (from dbus-1) or 'busctl' (from 
systemd), or a graphical one like d-feet or qdbus.

Something like:

dbus-send --print-reply --system --dest=org.ofono /phonesim 
org.ofono.VoicecallManager.SendTones string:"1234"

Replace /phonesim with the path of your modem device.

<snip>

>>
>> This function doesn't seem to be invoked?
> This function is passed into send_one_dtmf but yes, potentially goes unused,
> unless it gets invoked in the macro call?  Ill double-check the original
> implementation to see if i messed anything up, but open to suggestions :)

  I think your v4 implementation handled multiple characters correctly, just 
FYI.  Just the memory free paths were not completely correct.

Regards,
-Denis