Open Source Telephony
 help / color / mirror / Atom feed
* [PATCH 1/2] gatserver: Restore GAtServer disconnect handling
@ 2010-07-07  1:46 Zhenhua Zhang
  2010-07-07  1:46 ` [PATCH 2/2] gatppp: Unset disconnect function when unref PPP Zhenhua Zhang
  2010-07-07 16:27 ` [PATCH 1/2] gatserver: Restore GAtServer disconnect handling Denis Kenzior
  0 siblings, 2 replies; 3+ messages in thread
From: Zhenhua Zhang @ 2010-07-07  1:46 UTC (permalink / raw)
  To: ofono

[-- Attachment #1: Type: text/plain, Size: 610 bytes --]

Restore GAtServer disconnect handling when resuming a server session
---
 gatchat/gatserver.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/gatchat/gatserver.c b/gatchat/gatserver.c
index c63f04b..49e0de4 100644
--- a/gatchat/gatserver.c
+++ b/gatchat/gatserver.c
@@ -1166,6 +1166,8 @@ void g_at_server_resume(GAtServer *server)
 		return;
 	}
 
+	g_at_io_set_disconnect_function(server->io, io_disconnect, server);
+
 	g_at_io_set_debug(server->io, server->debugf, server->debug_data);
 	g_at_io_set_read_handler(server->io, new_bytes, server);
 
-- 
1.6.3.3


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH 2/2] gatppp: Unset disconnect function when unref PPP
  2010-07-07  1:46 [PATCH 1/2] gatserver: Restore GAtServer disconnect handling Zhenhua Zhang
@ 2010-07-07  1:46 ` Zhenhua Zhang
  2010-07-07 16:27 ` [PATCH 1/2] gatserver: Restore GAtServer disconnect handling Denis Kenzior
  1 sibling, 0 replies; 3+ messages in thread
From: Zhenhua Zhang @ 2010-07-07  1:46 UTC (permalink / raw)
  To: ofono

[-- Attachment #1: Type: text/plain, Size: 613 bytes --]

Unset IO disconnect function when we try to destroy GAtPPP instance.
After freeing the instance, the IO disconnect function should not be
invoked.
---
 gatchat/gatppp.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/gatchat/gatppp.c b/gatchat/gatppp.c
index d9b1627..63508b5 100644
--- a/gatchat/gatppp.c
+++ b/gatchat/gatppp.c
@@ -454,6 +454,9 @@ void g_at_ppp_unref(GAtPPP *ppp)
 	if (is_zero == FALSE)
 		return;
 
+	g_at_io_set_disconnect_function(g_at_hdlc_get_io(ppp->hdlc),
+						NULL, NULL);
+
 	if (ppp->net)
 		ppp_net_free(ppp->net);
 
-- 
1.6.3.3


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/2] gatserver: Restore GAtServer disconnect handling
  2010-07-07  1:46 [PATCH 1/2] gatserver: Restore GAtServer disconnect handling Zhenhua Zhang
  2010-07-07  1:46 ` [PATCH 2/2] gatppp: Unset disconnect function when unref PPP Zhenhua Zhang
@ 2010-07-07 16:27 ` Denis Kenzior
  1 sibling, 0 replies; 3+ messages in thread
From: Denis Kenzior @ 2010-07-07 16:27 UTC (permalink / raw)
  To: ofono

[-- Attachment #1: Type: text/plain, Size: 294 bytes --]

Hi Zhenhua,

On 07/06/2010 08:46 PM, Zhenhua Zhang wrote:
> Restore GAtServer disconnect handling when resuming a server session
> ---
>  gatchat/gatserver.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 

Both patches have been applied, thanks.

Regards,
-Denis

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2010-07-07 16:27 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-07-07  1:46 [PATCH 1/2] gatserver: Restore GAtServer disconnect handling Zhenhua Zhang
2010-07-07  1:46 ` [PATCH 2/2] gatppp: Unset disconnect function when unref PPP Zhenhua Zhang
2010-07-07 16:27 ` [PATCH 1/2] gatserver: Restore GAtServer disconnect handling Denis Kenzior

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox