From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH -v3 3/3] modem: add support to restore state when resetting the modem
Date: Tue, 23 Nov 2010 05:04:40 -0600 [thread overview]
Message-ID: <4CEB9FC8.6080504@gmail.com> (raw)
In-Reply-To: <1290202590-23190-3-git-send-email-padovan@profusion.mobi>
[-- Attachment #1: Type: text/plain, Size: 892 bytes --]
Hi Gustavo,
On 11/19/2010 03:36 PM, Gustavo F. Padovan wrote:
> ---
> src/modem.c | 74 ++++++++++++++++++++++++++++++++--------------------------
> 1 files changed, 41 insertions(+), 33 deletions(-)
>
Ah ok, you implement the getting back to online process in this patch.
Ignore my previous comment.
> diff --git a/src/modem.c b/src/modem.c
> index e57f8fc..704de29 100644
> --- a/src/modem.c
> +++ b/src/modem.c
> @@ -61,6 +61,7 @@ enum modem_state {
> struct ofono_modem {
> char *path;
> enum modem_state modem_state;
> + enum modem_state old_state;
Can we simply use a boolean like 'get_online' that is FALSE by default,
but gets set to TRUE (assuming we're online) during a silent reset?
This can then get re-used for implementing of the Lockdown property as well.
It also seems that the 'reset' value is not really needed.
Regards,
-Denis
next prev parent reply other threads:[~2010-11-23 11:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-19 21:36 [PATCH -v3 1/3] Add ofono_modem_reset() Gustavo F. Padovan
2010-11-19 21:36 ` [PATCH -v3 2/3] phonesim: Add modem reset trigger Gustavo F. Padovan
2010-11-19 21:36 ` [PATCH -v3 3/3] modem: add support to restore state when resetting the modem Gustavo F. Padovan
2010-11-23 11:04 ` Denis Kenzior [this message]
2010-11-23 17:50 ` Gustavo F. Padovan
2010-11-23 21:33 ` Gustavo F. Padovan
2010-11-23 22:07 ` Denis Kenzior
2010-11-23 10:59 ` [PATCH -v3 2/3] phonesim: Add modem reset trigger Denis Kenzior
2010-11-23 20:01 ` Gustavo F. Padovan
2010-11-23 21:52 ` Denis Kenzior
2010-11-23 10:57 ` [PATCH -v3 1/3] Add ofono_modem_reset() Denis Kenzior
2010-11-23 17:41 ` Gustavo F. Padovan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CEB9FC8.6080504@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox