Open Source Telephony
 help / color / mirror / Atom feed
From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH -v3 3/3] modem: add support to restore state when resetting the modem
Date: Tue, 23 Nov 2010 16:07:31 -0600	[thread overview]
Message-ID: <4CEC3B23.6040404@gmail.com> (raw)
In-Reply-To: <20101123213324.GF22502@vigoh>

[-- Attachment #1: Type: text/plain, Size: 917 bytes --]

Hi Gustavo,

>>>
>>> It also seems that the 'reset' value is not really needed.
>>
>> I'm using that to avoid emit DBus signal during the silent reset, Not
>> seeing how to do that without modem->reset, maybe we can rely on
>> modem->pending, not sure yet. 
> 
> Or do you mean that have DBus signaling about Powered and Online during
> silent reset is just fine? That is starting to make sense to me. We may
> want to notify users that the modem is not there.
> 

I actually think that emitting powered / online going on and off is
okay, there's no real way to hide this since all the atoms have to be
re-initialized.  So all the interfaces go away and magically re-appear,
all properties are re-emitted, etc.  Not emitting Powered or Online is
the least of our worries.

Silent resets are really just about avoiding having the user re-enter
the PIN when the modem crashes.

Regards,
-Denis

  reply	other threads:[~2010-11-23 22:07 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-19 21:36 [PATCH -v3 1/3] Add ofono_modem_reset() Gustavo F. Padovan
2010-11-19 21:36 ` [PATCH -v3 2/3] phonesim: Add modem reset trigger Gustavo F. Padovan
2010-11-19 21:36   ` [PATCH -v3 3/3] modem: add support to restore state when resetting the modem Gustavo F. Padovan
2010-11-23 11:04     ` Denis Kenzior
2010-11-23 17:50       ` Gustavo F. Padovan
2010-11-23 21:33         ` Gustavo F. Padovan
2010-11-23 22:07           ` Denis Kenzior [this message]
2010-11-23 10:59   ` [PATCH -v3 2/3] phonesim: Add modem reset trigger Denis Kenzior
2010-11-23 20:01     ` Gustavo F. Padovan
2010-11-23 21:52       ` Denis Kenzior
2010-11-23 10:57 ` [PATCH -v3 1/3] Add ofono_modem_reset() Denis Kenzior
2010-11-23 17:41   ` Gustavo F. Padovan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CEC3B23.6040404@gmail.com \
    --to=denkenz@gmail.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox