Property signal fix for data and fax call forwarding

Property signal fix for data and fax call forwarding

[Jeevaka Badrappan]

[-- Attachment #1: Type: text/plain, Size: 327 bytes --]


Hi,

 Data and Fax call forwarding is not supported in oFono. Currently, oFono triggers the property change only for voice call even when the Data/Fax call forwarding is active.
In one particular case, the Data and Fax property change gets triggered. This patch handles that particular case as well.

Regards,
Jeevaka

[PATCH] call-forwarding: skip property change data and fax

[Jeevaka Badrappan]

[-- Attachment #1: Type: text/plain, Size: 685 bytes --]

---
 src/call-forwarding.c |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)

diff --git a/src/call-forwarding.c b/src/call-forwarding.c
index 715ce02..ce03c40 100644
--- a/src/call-forwarding.c
+++ b/src/call-forwarding.c
@@ -285,6 +285,13 @@ static void set_new_cond_list(struct ofono_call_forwarding *cf,
 	for (o = old; o; o = o->next) {
 		oc = o->data;
 
+		/*
+		 * For now we only support Voice, although Fax & all Data
+		 * basic services are applicable as well.
+		 */
+		if (oc->cls > BEARER_CLASS_VOICE)
+			continue;
+
 		snprintf(attr, sizeof(attr), "%s%s",
 			bearer_class_to_string(oc->cls), cf_type_lut[type]);
 
-- 
1.7.0.4

Re: [PATCH] call-forwarding: skip property change data and fax

[Denis Kenzior]

[-- Attachment #1: Type: text/plain, Size: 238 bytes --]

Hi Jeevaka,

On 11/24/2010 03:57 AM, Jeevaka Badrappan wrote:
> ---
>  src/call-forwarding.c |    7 +++++++
>  1 files changed, 7 insertions(+), 0 deletions(-)
> 

Good catch, patch has been applied.  Thanks.

Regards,
-Denis