From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH] Specify vendor ID for Huawei modem while creating GPRS context
Date: Sat, 11 Dec 2010 11:40:31 -0600 [thread overview]
Message-ID: <4D03B78F.1090206@gmail.com> (raw)
In-Reply-To: <AANLkTikBCc8+4BpCu7=Dmi8BBDgDn9_ThvDzfKa5JTbo@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 815 bytes --]
Hi Tonny,
On 12/11/2010 10:37 AM, Tonny Tzeng wrote:
> Hi Denis,
>
> No, you don't. You are confusing gprs atom and the gprs-context atom.
> Grep for VENDOR in drivers/atmodem/gprs-context.c if you do not believe
> me. There is no vendor specific code in the atmodem gprs-context
> driver.
>
>
> Yes, my bad, I misunderstood the program flow...
> So, is huawei_post_online() in plugins/huawei.c the right place to pass
> the vendor ID while calling to ofono_gprs_create()?
Yes, I fixed this now as well.
>
> Together with the patch to fix parsing of unquoted CGREG, now I can get
> the CGREG status correctly from the Huawei modem. :) Thanks!
My earlier patch has been applied, so please test the upstream version
and report back any problems.
Regards,
-Denis
next prev parent reply other threads:[~2010-12-11 17:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-03 15:22 [PATCH] Specify vendor ID for Huawei modem while creating GPRS context Tonny Tzeng
2010-12-07 3:21 ` Denis Kenzior
2010-12-11 14:48 ` Tonny Tzeng
2010-12-11 14:55 ` Denis Kenzior
2010-12-11 16:37 ` Tonny Tzeng
2010-12-11 17:40 ` Denis Kenzior [this message]
2010-12-07 8:43 ` Kalle Valo
2010-12-07 10:29 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D03B78F.1090206@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox