Open Source Telephony
 help / color / mirror / Atom feed
From: Kalle Valo <kalle.valo@canonical.com>
To: ofono@ofono.org
Subject: Re: [PATCH] Specify vendor ID for Huawei modem while creating GPRS context
Date: Tue, 07 Dec 2010 10:43:22 +0200	[thread overview]
Message-ID: <87oc8y55xx.fsf@potku.valot.fi> (raw)
In-Reply-To: <1291389772.2043.27.camel@Twins.TonnyLab.net>

[-- Attachment #1: Type: text/plain, Size: 460 bytes --]

Hi Tonny,

Tonny Tzeng <tonny.tzeng@gmail.com> writes:

> ---
>  plugins/huawei.c |    8 ++++----
>  1 files changed, 4 insertions(+), 4 deletions(-)

Your commit log is empty. The most important part of the commit log is
to answer the question "Why?" and this patch really would need that
answer.

What's the bug are you fixing? Logs etc would help here. Also what is
the exact model of the Huawei modem with you see the bug?

-- 
Kalle Valo

  parent reply	other threads:[~2010-12-07  8:43 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-03 15:22 [PATCH] Specify vendor ID for Huawei modem while creating GPRS context Tonny Tzeng
2010-12-07  3:21 ` Denis Kenzior
2010-12-11 14:48   ` Tonny Tzeng
2010-12-11 14:55     ` Denis Kenzior
2010-12-11 16:37       ` Tonny Tzeng
2010-12-11 17:40         ` Denis Kenzior
2010-12-07  8:43 ` Kalle Valo [this message]
2010-12-07 10:29 ` Marcel Holtmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87oc8y55xx.fsf@potku.valot.fi \
    --to=kalle.valo@canonical.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox