From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 2/4] Core support for packet switched bearer reporting
Date: Mon, 10 Jan 2011 10:19:53 -0600 [thread overview]
Message-ID: <4D2B31A9.70202@gmail.com> (raw)
In-Reply-To: <201101101333.31577.remi.denis-courmont@nokia.com>
[-- Attachment #1: Type: text/plain, Size: 899 bytes --]
Hi Rémi,
On 01/10/2011 05:33 AM, Rémi Denis-Courmont wrote:
> On Friday 07 January 2011 18:25:32 ext Denis Kenzior, you wrote:
>> Hi Rémi,
>>
>> On 01/07/2011 10:02 AM, Rémi Denis-Courmont wrote:
>>> ---
>>>
>>> include/gprs.h | 2 ++
>>> src/gprs.c | 32 ++++++++++++++++++++++++++++++++
>>> 2 files changed, 34 insertions(+), 0 deletions(-)
>>
>> please see the 'Submitting patches' section in HACKING
>
> The rules are self-contradictory. Either the patch spreads multiple
> directories, or it breaks compilation.
>
They are really not. For 99% of the time you need to break up your
patches like this and it works out nicely.
> For the sake of git-bisect'ing, I'd rather not break compilation.
>
What are you talking about? Adding a function declaration that nobody
yet calls is not going to break compilation or git bisect.
Regards,
-Denis
next prev parent reply other threads:[~2011-01-10 16:19 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-07 16:02 [PATCH 1/4] Define packet switched bearers =?unknown-8bit?q?R=C3=A9mi?= Denis-Courmont
2011-01-07 16:02 ` [PATCH 2/4] Core support for packet switched bearer reporting =?unknown-8bit?q?R=C3=A9mi?= Denis-Courmont
2011-01-07 16:25 ` Denis Kenzior
2011-01-10 11:19 ` =?unknown-8bit?q?R=C3=A9mi?= Denis-Courmont
2011-01-10 16:16 ` Denis Kenzior
2011-01-10 11:33 ` =?unknown-8bit?q?R=C3=A9mi?= Denis-Courmont
2011-01-10 16:19 ` Denis Kenzior [this message]
2011-01-07 16:02 ` [PATCH 3/4] Bearer documentation =?unknown-8bit?q?R=C3=A9mi?= Denis-Courmont
2011-01-07 16:23 ` Denis Kenzior
2011-01-10 11:21 ` =?unknown-8bit?q?R=C3=A9mi?= Denis-Courmont
2011-01-10 16:27 ` Denis Kenzior
2011-01-10 16:34 ` =?unknown-8bit?q?R=C3=A9mi?= Denis-Courmont
2011-01-11 0:26 ` Marcel Holtmann
2011-01-11 7:53 ` Aki Niemi
2011-01-12 16:40 ` Marcel Holtmann
2011-01-13 8:17 ` =?unknown-8bit?q?R=C3=A9mi?= Denis-Courmont
2011-01-10 12:41 ` =?unknown-8bit?q?R=C3=A9mi?= Denis-Courmont
2011-01-10 16:20 ` Denis Kenzior
2011-01-07 16:02 ` [PATCH 4/4] atmodem: packet switch bearer support =?unknown-8bit?q?R=C3=A9mi?= Denis-Courmont
2011-01-07 16:27 ` Denis Kenzior
2011-01-07 16:23 ` [PATCH 1/4] Define packet switched bearers Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D2B31A9.70202@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox