From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 3/4] Bearer documentation
Date: Mon, 10 Jan 2011 10:20:58 -0600 [thread overview]
Message-ID: <4D2B31EA.6090408@gmail.com> (raw)
In-Reply-To: <201101101441.23644.remi.denis-courmont@nokia.com>
[-- Attachment #1: Type: text/plain, Size: 1460 bytes --]
Hi Rémi,
On 01/10/2011 06:41 AM, Rémi Denis-Courmont wrote:
> On Friday 07 January 2011 18:23:25 ext Denis Kenzior, you wrote:
>> Hi Rémi,
>>
>> On 01/07/2011 10:02 AM, Rémi Denis-Courmont wrote:
>>> ---
>>>
>>> doc/connman-api.txt | 10 ++++++++++
>>> 1 files changed, 10 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/doc/connman-api.txt b/doc/connman-api.txt
>>> index b13efd1..18185d7 100644
>>> --- a/doc/connman-api.txt
>>> +++ b/doc/connman-api.txt
>>> @@ -150,6 +150,16 @@ Properties boolean Active [readwrite]
>>>
>>> Holds whether the context is activated. This value
>>> can be set to activate / deactivate the context.
>>>
>>> + string Bearer [readonly, optional]
>>> +
>>> + Contains the current packet switched bearer of the
>>> + connection context.
>>> +
>>> + Possible values are the same as for the Technology
>>> + property the NetworkRegistration object, plus
>>> + "none" if no data activity is ongoing, or "unknown"
>>> + if not known.
>>> +
>>
>> Please remove this "unknown" bit. The property is already optional, so
>> if it is never reported by the driver we shouldn't report it up, even if
>> the context is active.
>
> That would not work. We need some default value otherwise we cannot signal the
> change from known to unknown, at least not with the oFono property change
> interface.
>
When do you think that will ever happen?
Regards,
-Denis
next prev parent reply other threads:[~2011-01-10 16:20 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-07 16:02 [PATCH 1/4] Define packet switched bearers =?unknown-8bit?q?R=C3=A9mi?= Denis-Courmont
2011-01-07 16:02 ` [PATCH 2/4] Core support for packet switched bearer reporting =?unknown-8bit?q?R=C3=A9mi?= Denis-Courmont
2011-01-07 16:25 ` Denis Kenzior
2011-01-10 11:19 ` =?unknown-8bit?q?R=C3=A9mi?= Denis-Courmont
2011-01-10 16:16 ` Denis Kenzior
2011-01-10 11:33 ` =?unknown-8bit?q?R=C3=A9mi?= Denis-Courmont
2011-01-10 16:19 ` Denis Kenzior
2011-01-07 16:02 ` [PATCH 3/4] Bearer documentation =?unknown-8bit?q?R=C3=A9mi?= Denis-Courmont
2011-01-07 16:23 ` Denis Kenzior
2011-01-10 11:21 ` =?unknown-8bit?q?R=C3=A9mi?= Denis-Courmont
2011-01-10 16:27 ` Denis Kenzior
2011-01-10 16:34 ` =?unknown-8bit?q?R=C3=A9mi?= Denis-Courmont
2011-01-11 0:26 ` Marcel Holtmann
2011-01-11 7:53 ` Aki Niemi
2011-01-12 16:40 ` Marcel Holtmann
2011-01-13 8:17 ` =?unknown-8bit?q?R=C3=A9mi?= Denis-Courmont
2011-01-10 12:41 ` =?unknown-8bit?q?R=C3=A9mi?= Denis-Courmont
2011-01-10 16:20 ` Denis Kenzior [this message]
2011-01-07 16:02 ` [PATCH 4/4] atmodem: packet switch bearer support =?unknown-8bit?q?R=C3=A9mi?= Denis-Courmont
2011-01-07 16:27 ` Denis Kenzior
2011-01-07 16:23 ` [PATCH 1/4] Define packet switched bearers Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D2B31EA.6090408@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox