From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [RFC 5/5] doc: Describe TextTelephony property
Date: Wed, 12 Jan 2011 23:20:41 -0600 [thread overview]
Message-ID: <4D2E8BA9.4070809@gmail.com> (raw)
In-Reply-To: <1294812055.3873.51.camel@aeonflux>
[-- Attachment #1: Type: text/plain, Size: 1017 bytes --]
Hi Marcel,
On 01/12/2011 12:00 AM, Marcel Holtmann wrote:
> Hi Jeevaka,
>
>> doc/voicecall-api.txt | 7 +++++++
>> 1 files changed, 7 insertions(+), 0 deletions(-)
>>
>> diff --git a/doc/voicecall-api.txt b/doc/voicecall-api.txt
>> index 4f38e6a..8df8fd2 100644
>> --- a/doc/voicecall-api.txt
>> +++ b/doc/voicecall-api.txt
>> @@ -100,6 +100,13 @@ Properties string LineIdentification [readonly]
>> Notifications if a call becomes part or leaves a
>> multipart call are sent.
>>
>> + boolean TextTelephony [readonly]
>> +
>> + Contains the indication if the voice call is a
>> + text telephony call or not.
>> +
>> + Notifications if a call is a text telephony call.
>> +
>> string State [readonly]
>>
>> Contains the state of the current call. The state
>
> I am fine with actually.
>
> Denis, any objections?
>
Based on what I have heard so far, this seems fine. However see my
concern in my reply to the IFX driver patch.
Regards,
-Denis
prev parent reply other threads:[~2011-01-13 5:20 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-10 14:01 [RFC 0/5] Add support for TextTelephony call notifications Jeevaka Badrappan
2011-01-10 14:01 ` [RFC 1/5] types: add tty flag to ofono_call Jeevaka Badrappan
2011-01-10 14:01 ` [RFC 2/5] voicecall: Add tty property support Jeevaka Badrappan
2011-01-10 14:01 ` [RFC 3/5] voicecall: Add ofono_voicecall_tty_notify api Jeevaka Badrappan
2011-01-12 6:03 ` Marcel Holtmann
2011-01-12 8:27 ` Jeevaka.Badrappan
2011-01-12 16:29 ` Marcel Holtmann
2011-01-12 16:42 ` Jeevaka.Badrappan
2011-01-12 16:48 ` Marcel Holtmann
2011-01-13 5:19 ` Denis Kenzior
2011-01-13 9:15 ` Kai.Vehmanen
2011-01-13 9:43 ` Jeevaka.Badrappan
2011-01-13 11:08 ` Kai.Vehmanen
2011-01-10 14:01 ` [RFC 4/5] ifxmodem: Add support for tty call notifications Jeevaka Badrappan
2011-01-13 5:23 ` Denis Kenzior
2011-01-10 14:01 ` [RFC 5/5] doc: Describe TextTelephony property Jeevaka Badrappan
2011-01-12 6:00 ` Marcel Holtmann
2011-01-13 5:20 ` Denis Kenzior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D2E8BA9.4070809@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox