From: Marcel Holtmann <marcel@holtmann.org>
To: ofono@ofono.org
Subject: Re: [RFC 3/5] voicecall: Add ofono_voicecall_tty_notify api
Date: Tue, 11 Jan 2011 22:03:34 -0800 [thread overview]
Message-ID: <1294812214.3873.52.camel@aeonflux> (raw)
In-Reply-To: <1294668092-27896-4-git-send-email-jeevaka.badrappan@elektrobit.com>
[-- Attachment #1: Type: text/plain, Size: 824 bytes --]
Hi Jeevaka,
> include/voicecall.h | 2 ++
> src/voicecall.c | 12 ++++++++++++
> 2 files changed, 14 insertions(+), 0 deletions(-)
>
> diff --git a/include/voicecall.h b/include/voicecall.h
> index e37d73b..6f1bdd2 100644
> --- a/include/voicecall.h
> +++ b/include/voicecall.h
> @@ -144,6 +144,8 @@ void ofono_voicecall_notify(struct ofono_voicecall *vc,
> void ofono_voicecall_disconnected(struct ofono_voicecall *vc, int id,
> enum ofono_disconnect_reason reason,
> const struct ofono_error *error);
> +void ofono_voicecall_tty_notify(struct ofono_voicecall *vc,
> + const struct ofono_call *call);
what is the advantage of having this separate and not part of the
regular voicecall_notify and just extending struct ofono_call with a
field for TTY?
Regards
Marcel
next prev parent reply other threads:[~2011-01-12 6:03 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-10 14:01 [RFC 0/5] Add support for TextTelephony call notifications Jeevaka Badrappan
2011-01-10 14:01 ` [RFC 1/5] types: add tty flag to ofono_call Jeevaka Badrappan
2011-01-10 14:01 ` [RFC 2/5] voicecall: Add tty property support Jeevaka Badrappan
2011-01-10 14:01 ` [RFC 3/5] voicecall: Add ofono_voicecall_tty_notify api Jeevaka Badrappan
2011-01-12 6:03 ` Marcel Holtmann [this message]
2011-01-12 8:27 ` Jeevaka.Badrappan
2011-01-12 16:29 ` Marcel Holtmann
2011-01-12 16:42 ` Jeevaka.Badrappan
2011-01-12 16:48 ` Marcel Holtmann
2011-01-13 5:19 ` Denis Kenzior
2011-01-13 9:15 ` Kai.Vehmanen
2011-01-13 9:43 ` Jeevaka.Badrappan
2011-01-13 11:08 ` Kai.Vehmanen
2011-01-10 14:01 ` [RFC 4/5] ifxmodem: Add support for tty call notifications Jeevaka Badrappan
2011-01-13 5:23 ` Denis Kenzior
2011-01-10 14:01 ` [RFC 5/5] doc: Describe TextTelephony property Jeevaka Badrappan
2011-01-12 6:00 ` Marcel Holtmann
2011-01-13 5:20 ` Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1294812214.3873.52.camel@aeonflux \
--to=marcel@holtmann.org \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox