From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 2/6] smsutil: Remove dialect checks from caller
Date: Thu, 03 Feb 2011 14:01:23 -0600 [thread overview]
Message-ID: <4D4B0993.1010607@gmail.com> (raw)
In-Reply-To: <1296739236-24391-3-git-send-email-aki.niemi@nokia.com>
[-- Attachment #1: Type: text/plain, Size: 1103 bytes --]
Hi Aki,
On 02/03/2011 07:20 AM, Aki Niemi wrote:
> ---
> src/smsutil.c | 10 ----------
> 1 files changed, 0 insertions(+), 10 deletions(-)
>
> diff --git a/src/smsutil.c b/src/smsutil.c
> index 1762391..5c1ae4c 100644
> --- a/src/smsutil.c
> +++ b/src/smsutil.c
> @@ -2267,16 +2267,6 @@ char *sms_decode_text(GSList *sms_list)
> sms_extract_language_variant(sms, &locking_shift,
> &single_shift);
>
> - /*
> - * If language is not defined in 3GPP TS 23.038,
> - * implementations are instructed to ignore it
> - */
> - if (locking_shift >= GSM_DIALECT_INVALID)
> - locking_shift = GSM_DIALECT_DEFAULT;
> -
> - if (single_shift >= GSM_DIALECT_INVALID)
> - single_shift = GSM_DIALECT_DEFAULT;
> -
> converted = convert_gsm_to_utf8_with_lang(buf, written,
> NULL, NULL, 0,
> locking_shift,
I'm pretty sure you want to leave this check in, otherwise you will not
be compliant with 23.040. If the dialect used is not understood, we
have to fall-back to the default, not ignore the message.
Regards,
-Denis
next prev parent reply other threads:[~2011-02-03 20:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-03 13:20 [PATCH 0/6] Add alphabet support to SMS Aki Niemi
2011-02-03 13:20 ` [PATCH 1/6] util: Refactor conversion table handling Aki Niemi
2011-02-03 20:38 ` Denis Kenzior
2011-02-03 13:20 ` [PATCH 2/6] smsutil: Remove dialect checks from caller Aki Niemi
2011-02-03 20:01 ` Denis Kenzior [this message]
2011-02-03 20:29 ` Aki Niemi
2011-02-03 13:20 ` [PATCH 3/6] util: Add best dialect picker API Aki Niemi
2011-02-03 20:39 ` Denis Kenzior
2011-02-03 13:20 ` [PATCH 4/6] smsutil: Add alphabet support to encoding Aki Niemi
2011-02-03 20:39 ` Denis Kenzior
2011-02-03 13:20 ` [PATCH 5/6] sms: Add alphabet support to SMS atom Aki Niemi
2011-02-04 18:48 ` Denis Kenzior
2011-02-03 13:20 ` [PATCH 6/6] doc: Add documentation for Alphabet property Aki Niemi
2011-02-03 20:40 ` Denis Kenzior
2011-02-04 18:49 ` Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D4B0993.1010607@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox