From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 6/6] doc: Add documentation for Alphabet property
Date: Thu, 03 Feb 2011 14:40:10 -0600 [thread overview]
Message-ID: <4D4B12AA.8010502@gmail.com> (raw)
In-Reply-To: <1296739236-24391-7-git-send-email-aki.niemi@nokia.com>
[-- Attachment #1: Type: text/plain, Size: 992 bytes --]
Hi Aki,
On 02/03/2011 07:20 AM, Aki Niemi wrote:
> ---
> doc/message-api.txt | 14 ++++++++++++++
> 1 files changed, 14 insertions(+), 0 deletions(-)
>
> diff --git a/doc/message-api.txt b/doc/message-api.txt
> index 1c68aee..d5a7b15 100644
> --- a/doc/message-api.txt
> +++ b/doc/message-api.txt
> @@ -24,3 +24,17 @@ Properties string State
> "pending",
> "sent",
> "failed"
> +
> + string Alphabet
> +
> + Contains the alphabet setting for outgoing SMSs.
> + Possible values are:
> +
> + "default" - Default GSM alphabet
> + "turkish" - Turkish alphabet
> + "spanish" - Spanish alphabet
> + "portuguese" - Portuguese alphabet
> +
> + The standard, language-specific alphabets are defined in
> + 3GPP TS23.038, Annex A. By default, oFono uses "default"
> + setting.
Before I look at patch 5, are you sure you want this as a property? I
thought you were a proponent of hiding this in main.conf?
Regards,
-Denis
next prev parent reply other threads:[~2011-02-03 20:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-03 13:20 [PATCH 0/6] Add alphabet support to SMS Aki Niemi
2011-02-03 13:20 ` [PATCH 1/6] util: Refactor conversion table handling Aki Niemi
2011-02-03 20:38 ` Denis Kenzior
2011-02-03 13:20 ` [PATCH 2/6] smsutil: Remove dialect checks from caller Aki Niemi
2011-02-03 20:01 ` Denis Kenzior
2011-02-03 20:29 ` Aki Niemi
2011-02-03 13:20 ` [PATCH 3/6] util: Add best dialect picker API Aki Niemi
2011-02-03 20:39 ` Denis Kenzior
2011-02-03 13:20 ` [PATCH 4/6] smsutil: Add alphabet support to encoding Aki Niemi
2011-02-03 20:39 ` Denis Kenzior
2011-02-03 13:20 ` [PATCH 5/6] sms: Add alphabet support to SMS atom Aki Niemi
2011-02-04 18:48 ` Denis Kenzior
2011-02-03 13:20 ` [PATCH 6/6] doc: Add documentation for Alphabet property Aki Niemi
2011-02-03 20:40 ` Denis Kenzior [this message]
2011-02-04 18:49 ` Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D4B12AA.8010502@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox