From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [RFC] voicecall API changes (proposal v3)
Date: Mon, 07 Feb 2011 10:38:42 -0600 [thread overview]
Message-ID: <4D502012.4050704@gmail.com> (raw)
In-Reply-To: <3150a4f74efe520f7c0dc81da26b016739b28784.1297076002.git.Andras.Domokos@nokia.com>
[-- Attachment #1: Type: text/plain, Size: 1060 bytes --]
Hi Andras,
> + CallForwarded(string type)
> +
> + Signal emitted when an outgoing voice call is made and
> + the call has been redirected to another number due to
> + the remote party's "Call Forwarding" Supplementary
> + Services settings. In this case the type parameter in
> + the signal is set to "outgoing".
You do not want to distinguish between conditional / unconditional?
Just checking here, either one is fine with me.
> + The signal is also emitted when the incoming voice call
> + is a redirected call due to a call forwarding operation.
> + In this case the type parameter in the signal is set to
> + "incoming".
> +
> +
> Properties array{string} EmergencyNumbers [readonly]
>
> Contains the list of emergency numbers recognized
The proposal looks good to me. I'd apply it, however git am complains:
Applying: voicecall API changes (proposal v3)
/home/denkenz/ofono-master/.git/rebase-apply/patch:32: new blank line at
EOF.
+
fatal: 1 line adds whitespace errors.
Regards,
-Denis
next prev parent reply other threads:[~2011-02-07 16:38 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1296474033.git.Andras.Domokos@nokia.com>
2011-01-31 11:56 ` [RFC] voice call API changes (proposal) Andras Domokos
2011-01-31 19:58 ` Denis Kenzior
2011-02-01 15:43 ` Andras Domokos
2011-02-01 15:54 ` Denis Kenzior
2011-02-02 7:51 ` Andras Domokos
2011-02-02 15:32 ` Denis Kenzior
2011-02-02 18:16 ` [RFC] voicecall API changes (proposal 2) Andras Domokos
2011-02-02 20:01 ` Denis Kenzior
2011-02-03 10:53 ` Andras Domokos
2011-02-03 16:29 ` Denis Kenzior
2011-02-07 11:18 ` [RFC] voicecall API changes (proposal v3) Andras Domokos
2011-02-07 16:38 ` Denis Kenzior [this message]
2011-02-07 17:07 ` Andras Domokos
2011-02-07 17:09 ` Andras Domokos
2011-02-07 19:39 ` Denis Kenzior
2011-02-08 8:55 ` Andras Domokos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D502012.4050704@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox