From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH] voicecall: fix transfer
Date: Mon, 07 Feb 2011 13:46:46 -0600 [thread overview]
Message-ID: <4D504C26.4030504@gmail.com> (raw)
In-Reply-To: <1297079813-26573-1-git-send-email-andre.matos.ste@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 888 bytes --]
Hi Andre,
> @@ -1350,11 +1351,12 @@ static DBusMessage *manager_transfer(DBusConnection *conn,
> * implementing the call transfer operation for a call that is
> * still dialing/alerting.
> */
> - numactive += voicecalls_num_connecting(vc);
> + numconn = voicecalls_num_connecting(vc);
>
> numheld = voicecalls_num_held(vc);
>
> - if ((numactive != 1) && (numheld != 1))
I don't get it, isn't the above condition taking care of this already?
Its been a while but the precondition of ECT is:
Held Call
Outgoing or an Active call. You cannot have an Outgoing and an Active
call at the same time. Hence numactive == 1 && numheld == 1 should work
just fine.
> + if ((numactive > 1 || numheld > 1) ||
> + ((numheld + numactive + numconn) != 2))
> return __ofono_error_failed(msg);
>
> if (vc->driver->transfer == NULL)
Regards,
-Denis
next prev parent reply other threads:[~2011-02-07 19:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-07 11:56 [PATCH] voicecall: fix transfer Andre Matos
2011-02-07 19:46 ` Denis Kenzior [this message]
2011-02-07 20:37 ` andre matos
2011-02-07 21:05 ` Denis Kenzior
2011-02-07 21:24 ` andre matos
2011-02-07 21:30 ` Denis Kenzior
2011-02-07 21:48 ` andre matos
2011-02-07 22:00 ` Denis Kenzior
2011-02-07 22:01 ` Denis Kenzior
[not found] <AANLkTi=ATGSivr65py3FZ4wNEqOjivv7i7WPnSrdZ0q0@mail.gmail.com>
2011-02-07 22:12 ` andre matos
2011-02-07 22:30 ` Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D504C26.4030504@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox