From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH] voicecall: fix transfer
Date: Mon, 07 Feb 2011 16:00:41 -0600 [thread overview]
Message-ID: <4D506B89.5050701@gmail.com> (raw)
In-Reply-To: <AANLkTik2cQV=xUygaK8Q-5Fdt=UuyyQ93tLAG0kqJEE0@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1043 bytes --]
Hi Andre,
On 02/07/2011 03:48 PM, andre matos wrote:
> Hi Denis,
>
> On Mon, Feb 7, 2011 at 10:30 PM, Denis Kenzior <denkenz@gmail.com
> <mailto:denkenz@gmail.com>> wrote:
>
> Hi Andre,
>
> > Are we reading the same code?
> >
> > for this case we have:
> > numactive != 1 ==> true
> > numheld != 1 ==> false
> >
> > (numactive != 1) && (numheld != 1) ==> false
> >
>
> Then shouldn't the patch simply be modified to if (numactive != 1 ||
> numheld != 1)?
>
>
> Yes, if you wish to sacrifice readability for simplicity.
>
Don't get too offended, the || was intended instead of && in the first
place. My brain just had wired crossed and I wasn't seeing why you
needed a 6 line patch to fix this.
> I find my version self explanatory.
>
Sorry, but I do not find your style more readable, less actually. Also,
when submitting patches please follow our coding style guidelines. You
had at least 1 style violation, namely rule M4.
Regards,
-Denis
next prev parent reply other threads:[~2011-02-07 22:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-07 11:56 [PATCH] voicecall: fix transfer Andre Matos
2011-02-07 19:46 ` Denis Kenzior
2011-02-07 20:37 ` andre matos
2011-02-07 21:05 ` Denis Kenzior
2011-02-07 21:24 ` andre matos
2011-02-07 21:30 ` Denis Kenzior
2011-02-07 21:48 ` andre matos
2011-02-07 22:00 ` Denis Kenzior [this message]
2011-02-07 22:01 ` Denis Kenzior
[not found] <AANLkTi=ATGSivr65py3FZ4wNEqOjivv7i7WPnSrdZ0q0@mail.gmail.com>
2011-02-07 22:12 ` andre matos
2011-02-07 22:30 ` Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D506B89.5050701@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox