From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH] reopen data device once if open data device failed
Date: Tue, 10 May 2011 22:45:38 -0500 [thread overview]
Message-ID: <4DCA0662.6090101@gmail.com> (raw)
In-Reply-To: <0E7E5CACD8E9F248AA009C292CC772A057B5DE@ALA-MBA.corp.ad.wrs.com>
[-- Attachment #1: Type: text/plain, Size: 803 bytes --]
Hi Caiwen,
>> I think this is wrong as well. We should remove that context no matter
>> if online of offline, but off course you do not wanna create a new GPRS
>> context if you are actually offline, right?
>>
>
> If the device is offline, the GPRS context atom has been released when set
> the device to offline. That's another issue has been fixed by Martin (Need
> set data->gc to NULL, because it has been release if device is offline).
>
> It will create a new GPRS context when the device is switch to online(in
> huawei_post_online()), so don't create it here if it is offline.
>
>
I suggest you migrate the huawei modem driver to create the gprs atom in
post_sim state instead of post_online. It will solve many of the issues
you're trying to solve.
Regards,
-Denis
next prev parent reply other threads:[~2011-05-11 3:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-11 2:25 [PATCH] reopen data device once if open data device failed Caiwen Zhang
2011-05-11 2:41 ` Marcel Holtmann
2011-05-11 3:41 ` Zhang, Caiwen
2011-05-11 3:45 ` Denis Kenzior [this message]
2011-05-11 5:49 ` Zhang, Caiwen
2011-05-11 16:21 ` Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DCA0662.6090101@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox