Re: [PATCH] reopen data device once if open data device failed

[Denis Kenzior <denkenz@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1733 bytes --]

Hi Caiwen,

On 05/11/2011 12:49 AM, Zhang, Caiwen wrote:
> Hi Denis,
> 
>>>> I think this is wrong as well. We should remove that context no
>> matter
>>>> if online of offline, but off course you do not wanna create a new
>> GPRS
>>>> context if you are actually offline, right?
>>>>
>>>
>>> If the device is offline, the GPRS context atom has been released
>> when set
>>> the device to offline. That's another issue has been fixed by Martin
>> (Need
>>> set data->gc to NULL, because it has been release if device is
>> offline).
>>>
>>> It will create a new GPRS context when the device is switch to
>> online(in
>>> huawei_post_online()), so don't create it here if it is offline.
>>>
>>>
>>
>> I suggest you migrate the huawei modem driver to create the gprs atom
>> in
>> post_sim state instead of post_online.  It will solve many of the
>> issues
>> you're trying to solve.
>>
> 
> Thanks your suggestion.
> 
> Yes, It can help that we don't need to care whether gprs atom and gprs context atom 
> be repeatedly created. But if do this at post_sim state, it will beak the rule
> that only enable the atom when it is available. At post_sim state GPRS is still unavailable.
> In addition, all other plug-ins do this at post_online, only do this in Huawei plug-in,
> it may impact the consistency of the codes.
> 

I wouldn't really suggest this if I didn't think it was a good idea.
All modem drivers should be migrated to create gprs in the post_sim
state instead of post_online at some point anyway.  And even if the GPRS
connections cannot be established when the modem is Offline, the
relevant settings on ConnectionManager interface can still be modified.

Regards,
-Denis