From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH_v6 2/5] private-network: add header into include and Makefile.am
Date: Wed, 25 May 2011 05:38:08 -0500 [thread overview]
Message-ID: <4DDCDC10.20801@gmail.com> (raw)
In-Reply-To: <1305799112-14289-3-git-send-email-guillaume.zajac@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 664 bytes --]
Hi Guillaume,
On 05/19/2011 04:58 AM, Guillaume Zajac wrote:
> ---
> Makefile.am | 4 +-
> include/private-network.h | 56 +++++++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 58 insertions(+), 2 deletions(-)
> create mode 100644 include/private-network.h
I applied this patch, however I did fix up a few things afterwards:
> +typedef void (ofono_private_network_cb_t)(
Please make sure that this is a pointer, e.g. typedef void (*foo)(...);
> + void *data,
> + const struct ofono_private_network_settings *settings);
It is customary to have the userdata pointer as the last argument
Regards,
-Denis
next prev parent reply other threads:[~2011-05-25 10:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-19 9:58 [PATCH_v6 0/5] Private network request to ConnMan Guillaume Zajac
2011-05-19 9:58 ` [PATCH_v6 1/5] gatppp: Add new contructor to use external fd Guillaume Zajac
2011-05-25 10:36 ` Denis Kenzior
2011-05-19 9:58 ` [PATCH_v6 2/5] private-network: add header into include and Makefile.am Guillaume Zajac
2011-05-25 10:38 ` Denis Kenzior [this message]
2011-05-19 9:58 ` [PATCH_v6 3/5] private-network: add request/release functions and new feature to Makefile.am Guillaume Zajac
2011-05-25 10:38 ` Denis Kenzior
2011-05-19 9:58 ` [PATCH_v6 4/5] emulator: add request/release private network calls Guillaume Zajac
2011-05-25 10:46 ` Denis Kenzior
2011-05-30 13:25 ` Guillaume Zajac
2011-05-19 9:58 ` [PATCH_v6 5/5] connman: add plugin in oFono to request/release private network Guillaume Zajac
2011-06-02 2:53 ` Denis Kenzior
-- strict thread matches above, loose matches on Subject: below --
2011-05-19 9:55 [PATCH_v6 0/5] *** SUBJECT HERE *** Guillaume Zajac
2011-05-19 9:55 ` [PATCH_v6 2/5] private-network: add header into include and Makefile.am Guillaume Zajac
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DDCDC10.20801@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox