From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH_v6 4/5] emulator: add request/release private network calls
Date: Wed, 25 May 2011 05:46:15 -0500 [thread overview]
Message-ID: <4DDCDDF7.2020401@gmail.com> (raw)
In-Reply-To: <1305799112-14289-5-git-send-email-guillaume.zajac@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 625 bytes --]
Hi Guillaume,
On 05/19/2011 04:58 AM, Guillaume Zajac wrote:
> ---
> src/emulator.c | 75 ++++++++++++++++++++++++++++++++++++++++++++++++-------
> 1 files changed, 65 insertions(+), 10 deletions(-)
>
I applied this patch, but have done heavy refactoring afterwards.
Please review all my changes (~20 or so patches intermixed with yours)
and make sure everything makes sense. I lightly tested this
functionality with gsmdial and everything seems to be performing well.
However, please test it really well yourself, use valgrind and try every
exceptional condition you can think of.
Regards,
-Denis
next prev parent reply other threads:[~2011-05-25 10:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-19 9:58 [PATCH_v6 0/5] Private network request to ConnMan Guillaume Zajac
2011-05-19 9:58 ` [PATCH_v6 1/5] gatppp: Add new contructor to use external fd Guillaume Zajac
2011-05-25 10:36 ` Denis Kenzior
2011-05-19 9:58 ` [PATCH_v6 2/5] private-network: add header into include and Makefile.am Guillaume Zajac
2011-05-25 10:38 ` Denis Kenzior
2011-05-19 9:58 ` [PATCH_v6 3/5] private-network: add request/release functions and new feature to Makefile.am Guillaume Zajac
2011-05-25 10:38 ` Denis Kenzior
2011-05-19 9:58 ` [PATCH_v6 4/5] emulator: add request/release private network calls Guillaume Zajac
2011-05-25 10:46 ` Denis Kenzior [this message]
2011-05-30 13:25 ` Guillaume Zajac
2011-05-19 9:58 ` [PATCH_v6 5/5] connman: add plugin in oFono to request/release private network Guillaume Zajac
2011-06-02 2:53 ` Denis Kenzior
-- strict thread matches above, loose matches on Subject: below --
2011-05-19 9:55 [PATCH_v6 0/5] *** SUBJECT HERE *** Guillaume Zajac
2011-05-19 9:55 ` [PATCH_v6 4/5] emulator: add request/release private network calls Guillaume Zajac
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DDCDDF7.2020401@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox