Re: [PATCH 1/2] GAtPPP: Add ACFC option support

[Denis Kenzior <denkenz@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1527 bytes --]

Hi Guillaume,

On 06/24/2011 10:20 AM, Guillaume Zajac wrote:
> Hi Denis,
> 
> On 24/06/2011 16:42, Denis Kenzior wrote:
>> Hi Guillaume,
>>
>>>> Again, this seems wrong.  What is happening here is that the peer just
>>>> told us that 'Yes, I can accept ACFC packets'.
>>>>
>>>> What you're trying to do is set whether our end can accept ACFC packets
>>>> based on whether the peer can.  In fact, they are completely
>>>> independent.  The relationship can be asymmetric, e.g. client that can
>>>> send ACFC packets, but not accept them, and vice versa.  You need to
>>>> account for this.
>>>>
>>> Right, so if we always set by default ACFC options into LCP configure
>>> request.
>>> I could dot into
>>>
>>> static void lcp_reset_config_options(struct lcp_data *lcp)
>>> {
>>>      /* Using the default ACCM */
>>>      lcp->req_options |= REQ_OPTION_ACFC;
>>>      lcp_generate_config_options(lcp);
>>> }
>>>
>>>
>>> On reception, we always say we can receive ACFC packet then it is up to
>>> the peer to transmit or not ACFC packets.
>>>
>>> GAtPPP object only needs to know if it has to transmit or not ACFC
>>> packets.
>>> That is the purpose of ppp->acfc.
>> I'd like to have the option of turning off ACFC completely, so it should
>> control:
>> 1. Whether we advertise that we can receive ACFC packets
>> 2. Whether we should try to send ACFC packets
>>
> 
> Fine I will add it.
> I guess we will need same kind of options for PFC.
> 

Yes please ;)

Regards,
-Denis