Open Source Telephony
 help / color / mirror / Atom feed
From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH v3 06/15] doc: Handsfree exposes supported AG features
Date: Thu, 20 Oct 2011 20:36:25 -0500	[thread overview]
Message-ID: <4EA0CC99.80304@gmail.com> (raw)
In-Reply-To: <1319128700-15841-7-git-send-email-mikel.astiz@bmw-carit.de>

[-- Attachment #1: Type: text/plain, Size: 1103 bytes --]

Hi Mikel,

On 10/20/2011 11:38 AM, Mikel Astiz wrote:
> ---
>  doc/handsfree-api.txt |    9 ++++++++-
>  1 files changed, 8 insertions(+), 1 deletions(-)
> 
> diff --git a/doc/handsfree-api.txt b/doc/handsfree-api.txt
> index 9355946..12cfe62 100644
> --- a/doc/handsfree-api.txt
> +++ b/doc/handsfree-api.txt
> @@ -38,7 +38,14 @@ Signals		PropertyChanged(string property, variant value)
>  			Signal is emitted whenever a property has changed.
>  			The new value is passed as the signal argument.
>  
> -Properties	boolean InbandRinging [readonly]
> +Properties	array{string} Features [readonly]
> +
> +			List of features supported by the AG. The currently
> +			supported values are:
> +				"VoiceRecognition"
> +				"AttachVoiceTag"
> +

Please use small caps and hyphens for values, e.g. 'voice-recognition',
'attach-voice-tag', etc.  See other BlueZ/oFono/ConnMan style APIs for
details.  Only properties and functions are CamelCased.

> +		boolean InbandRinging [readonly]
>  
>  			Boolean representing whether inband ringing is enabled.
>  

Regards,
-Denis

  reply	other threads:[~2011-10-21  1:36 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-20 16:38 [PATCH v3 00/15] Bluetooth HFP-specific extensions Mikel Astiz
2011-10-20 16:38 ` [PATCH v3 01/15] hfpmodem: Support for +BSIR unsol. result codes Mikel Astiz
2011-10-20 17:58   ` Denis Kenzior
2011-10-20 16:38 ` [PATCH v3 02/15] doc: Voice recognition function added in Handsfree Mikel Astiz
2011-10-21  1:33   ` Denis Kenzior
2011-10-20 16:38 ` [PATCH v3 03/15] include: Voice recognition in handsfree public api Mikel Astiz
2011-10-21  1:27   ` Denis Kenzior
2011-10-20 16:38 ` [PATCH v3 04/15] handsfree: Implement voice recognition function Mikel Astiz
2011-10-21  1:32   ` Denis Kenzior
2011-10-20 16:38 ` [PATCH v3 05/15] hfpmodem: Support for AT+BVRA Mikel Astiz
2011-10-20 16:38 ` [PATCH v3 06/15] doc: Handsfree exposes supported AG features Mikel Astiz
2011-10-21  1:36   ` Denis Kenzior [this message]
2011-10-20 16:38 ` [PATCH v3 07/15] include: AG features added to handsfree public api Mikel Astiz
2011-10-21  1:38   ` Denis Kenzior
2011-10-20 16:38 ` [PATCH v3 08/15] handsfree: Supported AG features exposed in D-Bus Mikel Astiz
2011-10-20 16:38 ` [PATCH v3 09/15] hfpmodem: Report features supported by AG Mikel Astiz
2011-10-20 16:38 ` [PATCH v3 10/15] hfpmodem: Avoid segfault in network-registration Mikel Astiz
2011-10-20 17:59   ` Denis Kenzior
2011-10-20 16:38 ` [PATCH v3 11/15] hfpmodem: Avoid segfault in call-volume Mikel Astiz
2011-10-20 16:38 ` [PATCH v3 12/15] hfpmodem: Avoid segfault in handsfree Mikel Astiz
2011-10-20 16:38 ` [PATCH v3 13/15] hfpmodem: devinfo atom added to export BT address Mikel Astiz
2011-10-21  1:40   ` Denis Kenzior
2011-10-20 16:38 ` [PATCH v3 14/15] hfp_hf: BT address exposed through Serial property Mikel Astiz
2011-10-21  1:42   ` Denis Kenzior
2011-10-20 16:38 ` [PATCH v3 15/15] hfpmodem: minor whitespace fix Mikel Astiz
2011-10-20 17:58   ` Denis Kenzior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EA0CC99.80304@gmail.com \
    --to=denkenz@gmail.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox