From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH v3 14/15] hfp_hf: BT address exposed through Serial property
Date: Thu, 20 Oct 2011 20:42:31 -0500 [thread overview]
Message-ID: <4EA0CE07.8080504@gmail.com> (raw)
In-Reply-To: <1319128700-15841-15-git-send-email-mikel.astiz@bmw-carit.de>
[-- Attachment #1: Type: text/plain, Size: 1559 bytes --]
Hi Mikel,
On 10/20/2011 11:38 AM, Mikel Astiz wrote:
> ---
> plugins/hfp_hf.c | 7 +++++++
> 1 files changed, 7 insertions(+), 0 deletions(-)
>
> diff --git a/plugins/hfp_hf.c b/plugins/hfp_hf.c
> index ba06434..bceae55 100644
> --- a/plugins/hfp_hf.c
> +++ b/plugins/hfp_hf.c
> @@ -38,12 +38,14 @@
> #include <ofono/plugin.h>
> #include <ofono/log.h>
> #include <ofono/modem.h>
> +#include <ofono/devinfo.h>
> #include <ofono/netreg.h>
> #include <ofono/voicecall.h>
> #include <ofono/call-volume.h>
> #include <ofono/handsfree.h>
>
> #include <drivers/hfpmodem/slc.h>
> +#include <drivers/hfpmodem/hfpmodem.h>
>
> #include "bluetooth.h"
>
> @@ -207,6 +209,7 @@ static int hfp_hf_probe(const char *device, const char *dev_addr,
> struct ofono_modem *modem;
> struct hfp_data *data;
> char buf[256];
> + struct hfp_devinfo_params devinfo_params;
>
> /* We already have this device in our hash, ignore */
> if (g_hash_table_lookup(modem_hash, device) != NULL)
> @@ -232,6 +235,10 @@ static int hfp_hf_probe(const char *device, const char *dev_addr,
>
> ofono_modem_set_data(modem, data);
> ofono_modem_set_name(modem, alias);
> +
> + devinfo_params.device_address = dev_addr;
> + ofono_devinfo_create(modem, 0, "hfpmodem", &devinfo_params);
> +
This looks way too complicated, why don't you just pass the const char
*dev_addr to ofono_devinfo_create?
> ofono_modem_register(modem);
>
> g_hash_table_insert(modem_hash, g_strdup(device), modem);
Regards,
-Denis
next prev parent reply other threads:[~2011-10-21 1:42 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-20 16:38 [PATCH v3 00/15] Bluetooth HFP-specific extensions Mikel Astiz
2011-10-20 16:38 ` [PATCH v3 01/15] hfpmodem: Support for +BSIR unsol. result codes Mikel Astiz
2011-10-20 17:58 ` Denis Kenzior
2011-10-20 16:38 ` [PATCH v3 02/15] doc: Voice recognition function added in Handsfree Mikel Astiz
2011-10-21 1:33 ` Denis Kenzior
2011-10-20 16:38 ` [PATCH v3 03/15] include: Voice recognition in handsfree public api Mikel Astiz
2011-10-21 1:27 ` Denis Kenzior
2011-10-20 16:38 ` [PATCH v3 04/15] handsfree: Implement voice recognition function Mikel Astiz
2011-10-21 1:32 ` Denis Kenzior
2011-10-20 16:38 ` [PATCH v3 05/15] hfpmodem: Support for AT+BVRA Mikel Astiz
2011-10-20 16:38 ` [PATCH v3 06/15] doc: Handsfree exposes supported AG features Mikel Astiz
2011-10-21 1:36 ` Denis Kenzior
2011-10-20 16:38 ` [PATCH v3 07/15] include: AG features added to handsfree public api Mikel Astiz
2011-10-21 1:38 ` Denis Kenzior
2011-10-20 16:38 ` [PATCH v3 08/15] handsfree: Supported AG features exposed in D-Bus Mikel Astiz
2011-10-20 16:38 ` [PATCH v3 09/15] hfpmodem: Report features supported by AG Mikel Astiz
2011-10-20 16:38 ` [PATCH v3 10/15] hfpmodem: Avoid segfault in network-registration Mikel Astiz
2011-10-20 17:59 ` Denis Kenzior
2011-10-20 16:38 ` [PATCH v3 11/15] hfpmodem: Avoid segfault in call-volume Mikel Astiz
2011-10-20 16:38 ` [PATCH v3 12/15] hfpmodem: Avoid segfault in handsfree Mikel Astiz
2011-10-20 16:38 ` [PATCH v3 13/15] hfpmodem: devinfo atom added to export BT address Mikel Astiz
2011-10-21 1:40 ` Denis Kenzior
2011-10-20 16:38 ` [PATCH v3 14/15] hfp_hf: BT address exposed through Serial property Mikel Astiz
2011-10-21 1:42 ` Denis Kenzior [this message]
2011-10-20 16:38 ` [PATCH v3 15/15] hfpmodem: minor whitespace fix Mikel Astiz
2011-10-20 17:58 ` Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EA0CE07.8080504@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox