From: Oleg Zhurakivskyy <oleg.zhurakivskyy@intel.com>
To: ofono@ofono.org
Subject: Re: [PATCHv2 6/8] call-forwarding: Don't run conditional queries if cfu is active
Date: Thu, 23 Feb 2012 11:51:35 +0200 [thread overview]
Message-ID: <4F460C27.8040102@intel.com> (raw)
In-Reply-To: <4F44EC8E.90501@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 699 bytes --]
Hello Denis,
On 02/22/2012 03:24 PM, Denis Kenzior wrote:
> The rest is on the right track, however I don't think this really works
> in the case where CFU is set when the query is being performed for the
> first time.
>
> e.g.
> - GetProperties -> query all
> - CFU is set, so don't query conditionals (which is correct since they
> are useless)
> - CFU is removed -> conditionals need to be updated now since they don't
> reflect reality
Thanks for the review and for pointing this out. I will check how this could be
corrected.
Regards,
Oleg
--
Intel Finland Oy
Registered Address: PL 281, 00181 Helsinki
Business Identity Code: 0357606 - 4
Domiciled in Helsinki
next prev parent reply other threads:[~2012-02-23 9:51 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-06 12:33 [PATCHv2 0/8] Call forwarding state handling change Oleg Zhurakivskyy
2012-02-06 12:33 ` [PATCHv2 1/8] call-forwarding: Minor style fixes Oleg Zhurakivskyy
2012-02-22 10:25 ` Denis Kenzior
2012-02-06 12:33 ` [PATCHv2 2/8] call-forwarding: Minor refactoring of is_cfu_enabled() Oleg Zhurakivskyy
2012-02-22 10:25 ` Denis Kenzior
2012-02-06 12:33 ` [PATCHv2 3/8] call-forwarding: Don't set conditional cfs when cfu is active Oleg Zhurakivskyy
2012-02-22 10:34 ` Denis Kenzior
2012-02-06 12:33 ` [PATCHv2 4/8] call-forwarding: Don't report " Oleg Zhurakivskyy
2012-02-22 13:19 ` Denis Kenzior
2012-02-06 12:33 ` [PATCHv2 5/8] call-forwarding: Emit signals to mask/unmask conditional cfs Oleg Zhurakivskyy
2012-02-22 13:19 ` Denis Kenzior
2012-02-06 12:33 ` [PATCHv2 6/8] call-forwarding: Don't run conditional queries if cfu is active Oleg Zhurakivskyy
2012-02-22 13:24 ` Denis Kenzior
2012-02-23 9:51 ` Oleg Zhurakivskyy [this message]
2012-02-06 12:34 ` [PATCHv2 7/8] call-forwarding: Clear the conditional cache flag Oleg Zhurakivskyy
2012-02-22 13:33 ` Denis Kenzior
2012-02-23 9:52 ` Oleg Zhurakivskyy
2012-02-06 12:34 ` [PATCHv2 8/8] TODO: Remove completed call forwarding state task Oleg Zhurakivskyy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F460C27.8040102@intel.com \
--to=oleg.zhurakivskyy@intel.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox