Open Source Telephony
 help / color / mirror / Atom feed
From: Oleg Zhurakivskyy <oleg.zhurakivskyy@intel.com>
To: ofono@ofono.org
Subject: Re: [PATCHv2 7/8] call-forwarding: Clear the conditional cache flag
Date: Thu, 23 Feb 2012 11:52:04 +0200	[thread overview]
Message-ID: <4F460C44.2000004@intel.com> (raw)
In-Reply-To: <4F44EE9B.8000407@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1242 bytes --]

Hello Denis,

On 02/22/2012 03:33 PM, Denis Kenzior wrote:
> This would cause us to re-query everything, which is a bit wasteful.
> Also, you have to handle the same action that might occur during
> supplementary services path, e.g. the user might deactivate / erase a
> conditional service there (see cf_ss_control and
> cf_ss_control_callback).  The DisableAll path also needs to be handled
> properly.
>
> Also, there is another path you need to take under consideration and
> that is the supplementary service interrogation path.  That one can
> update conditional settings erroneously if CFU is active.  See
> ss_set_query_cf_callback.
>
> We might need to track CFU and conditional caches separately to make
> things easier.  Let me know if you have any questions.  CallForwarding
> was one of the earliest implemented interfaces and turned out to be
> quite a bit more complicated than originally thought ;)

Thanks for the help and ideas here. Let me check the supplementary services path 
and how to deal with the caching. I will prepare patches to address these.

Regards,
Oleg
-- 
Intel Finland Oy
Registered Address: PL 281, 00181 Helsinki
Business Identity Code: 0357606 - 4
Domiciled in Helsinki


  reply	other threads:[~2012-02-23  9:52 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-06 12:33 [PATCHv2 0/8] Call forwarding state handling change Oleg Zhurakivskyy
2012-02-06 12:33 ` [PATCHv2 1/8] call-forwarding: Minor style fixes Oleg Zhurakivskyy
2012-02-22 10:25   ` Denis Kenzior
2012-02-06 12:33 ` [PATCHv2 2/8] call-forwarding: Minor refactoring of is_cfu_enabled() Oleg Zhurakivskyy
2012-02-22 10:25   ` Denis Kenzior
2012-02-06 12:33 ` [PATCHv2 3/8] call-forwarding: Don't set conditional cfs when cfu is active Oleg Zhurakivskyy
2012-02-22 10:34   ` Denis Kenzior
2012-02-06 12:33 ` [PATCHv2 4/8] call-forwarding: Don't report " Oleg Zhurakivskyy
2012-02-22 13:19   ` Denis Kenzior
2012-02-06 12:33 ` [PATCHv2 5/8] call-forwarding: Emit signals to mask/unmask conditional cfs Oleg Zhurakivskyy
2012-02-22 13:19   ` Denis Kenzior
2012-02-06 12:33 ` [PATCHv2 6/8] call-forwarding: Don't run conditional queries if cfu is active Oleg Zhurakivskyy
2012-02-22 13:24   ` Denis Kenzior
2012-02-23  9:51     ` Oleg Zhurakivskyy
2012-02-06 12:34 ` [PATCHv2 7/8] call-forwarding: Clear the conditional cache flag Oleg Zhurakivskyy
2012-02-22 13:33   ` Denis Kenzior
2012-02-23  9:52     ` Oleg Zhurakivskyy [this message]
2012-02-06 12:34 ` [PATCHv2 8/8] TODO: Remove completed call forwarding state task Oleg Zhurakivskyy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F460C44.2000004@intel.com \
    --to=oleg.zhurakivskyy@intel.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox