[PATCH 1/2] sim900: Add support for SIMCOM SMS delivery reports

[PATCH 1/2] sim900: Add support for SIMCOM SMS delivery reports

[r.r.zaripov]

[-- Attachment #1: Type: text/plain, Size: 643 bytes --]

From: Renat Zaripov <r.r.zaripov@gmail.com>

---
 plugins/sim900.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/plugins/sim900.c b/plugins/sim900.c
index f7b1642..b2d1b46 100644
--- a/plugins/sim900.c
+++ b/plugins/sim900.c
@@ -224,7 +224,8 @@ static void sim900_post_sim(struct ofono_modem *modem)
 	DBG("%p", modem);
 
 	ofono_phonebook_create(modem, 0, "atmodem", data->modem);
-	ofono_sms_create(modem, 0, "atmodem", data->modem);
+	ofono_sms_create(modem, OFONO_VENDOR_SIMCOM, "atmodem", 
+				data->modem);
 }
 
 static void sim900_post_online(struct ofono_modem *modem)
-- 
1.7.7.3

[PATCH 2/2] sim900: Disable sending AT+CNMA

[r.r.zaripov]

[-- Attachment #1: Type: text/plain, Size: 1040 bytes --]

From: Renat Zaripov <r.r.zaripov@gmail.com>

 SIMCOM SIM900 modem module not support AT+CNMA command
 
---
 drivers/atmodem/sms.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/drivers/atmodem/sms.c b/drivers/atmodem/sms.c
index c6fb8c4..c31eb39 100644
--- a/drivers/atmodem/sms.c
+++ b/drivers/atmodem/sms.c
@@ -389,6 +389,7 @@ static void at_cds_notify(GAtResult *result, gpointer user_data)
 static void at_cmt_notify(GAtResult *result, gpointer user_data)
 {
 	struct ofono_sms *sms = user_data;
+	struct sms_data *data = ofono_sms_get_data(sms);
 	const char *hexpdu;
 	long pdu_len;
 	int tpdu_len;
@@ -409,7 +410,8 @@ static void at_cmt_notify(GAtResult *result, gpointer user_data)
 	decode_hex_own_buf(hexpdu, -1, &pdu_len, 0, pdu);
 	ofono_sms_deliver_notify(sms, pdu, pdu_len, tpdu_len);
 
-	at_ack_delivery(sms);
+	if (data->vendor != OFONO_VENDOR_SIMCOM)
+		at_ack_delivery(sms);
 }
 
 static void at_cmgr_notify(GAtResult *result, gpointer user_data)
-- 
1.7.7.3

Re: [PATCH 1/2] sim900: Add support for SIMCOM SMS delivery reports

[Denis Kenzior]

[-- Attachment #1: Type: text/plain, Size: 1015 bytes --]

Hi Renat,

On 02/27/2012 01:19 AM, r.r.zaripov(a)gmail.com wrote:
> From: Renat Zaripov <r.r.zaripov@gmail.com>
> 
> ---
>  plugins/sim900.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/plugins/sim900.c b/plugins/sim900.c
> index f7b1642..b2d1b46 100644
> --- a/plugins/sim900.c
> +++ b/plugins/sim900.c
> @@ -224,7 +224,8 @@ static void sim900_post_sim(struct ofono_modem *modem)
>  	DBG("%p", modem);
>  
>  	ofono_phonebook_create(modem, 0, "atmodem", data->modem);
> -	ofono_sms_create(modem, 0, "atmodem", data->modem);
> +	ofono_sms_create(modem, OFONO_VENDOR_SIMCOM, "atmodem", 

I had to fix up a trailing whitespace error at the end of this line.  It
might be a good idea to configure your editor to show these, or use
checkpatch.pl from the Linux kernel to check the patches before submission.

> +				data->modem);
>  }
>  
>  static void sim900_post_online(struct ofono_modem *modem)

Patch has been applied, thanks.

Regards,
-Denis

Re: [PATCH 2/2] sim900: Disable sending AT+CNMA

[Denis Kenzior]

[-- Attachment #1: Type: text/plain, Size: 341 bytes --]

Hi Renat,

On 02/27/2012 01:19 AM, r.r.zaripov(a)gmail.com wrote:
> From: Renat Zaripov <r.r.zaripov@gmail.com>
> 
>  SIMCOM SIM900 modem module not support AT+CNMA command
>  
> ---
>  drivers/atmodem/sms.c |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
> 

Patch has been applied, thanks.

Regards,
-Denis