From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [RFC PATCH 3/3] huawei: Set property "AlwaysOnline" for CDMA modems
Date: Thu, 28 Mar 2013 09:54:42 -0500 [thread overview]
Message-ID: <515459B2.5020801@gmail.com> (raw)
In-Reply-To: <20130328142245.GI29445@alittletooquiet.net>
[-- Attachment #1: Type: text/plain, Size: 958 bytes --]
Hi Forest,
On 03/28/2013 09:22 AM, Forest Bond wrote:
> From: Forest Bond<forest.bond@rapidrollout.com>
>
> ---
> plugins/huawei.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/plugins/huawei.c b/plugins/huawei.c
> index 5d8875a..0621d5b 100644
> --- a/plugins/huawei.c
> +++ b/plugins/huawei.c
> @@ -377,6 +377,9 @@ static void cfun_offline(gboolean ok, GAtResult *result, gpointer user_data)
> return;
> }
>
> + if (data->have_gsm == FALSE&& data->have_cdma == TRUE)
> + ofono_modem_set_boolean(modem, "AlwaysOnline", TRUE);
> +
> ofono_modem_set_powered(modem, TRUE);
> }
>
Things don't seem to be this simple. The Huawei driver sets the modem
offline as part of the init procedure (grep for 'offline_command'). So
once we enable the device, it is put into radio off mode. With the
changes you're proposing there will be no way to get it online ;)
Regards,
-Denis
next prev parent reply other threads:[~2013-03-28 14:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-28 14:21 [RFC PATCH 0/3] Fix CDMA support with composite plugins Forest Bond
2013-03-28 14:22 ` [RFC PATCH 1/3] modem: Allow setting boolean properties Forest Bond
2013-03-28 14:52 ` Denis Kenzior
2013-03-28 14:22 ` [RFC PATCH 2/3] modem: Support modem property "AlwaysOnline" Forest Bond
2013-03-28 14:55 ` Denis Kenzior
2013-03-28 15:36 ` Forest Bond
2013-03-28 16:05 ` Denis Kenzior
2013-03-28 16:33 ` Forest Bond
2013-03-28 14:22 ` [RFC PATCH 3/3] huawei: Set property "AlwaysOnline" for CDMA modems Forest Bond
2013-03-28 14:54 ` Denis Kenzior [this message]
2013-03-28 15:34 ` Forest Bond
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=515459B2.5020801@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox