From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [RFC PATCH 2/3] modem: Support modem property "AlwaysOnline"
Date: Thu, 28 Mar 2013 11:05:38 -0500 [thread overview]
Message-ID: <51546A52.70405@gmail.com> (raw)
In-Reply-To: <20130328153635.GK29445@alittletooquiet.net>
[-- Attachment #1: Type: text/plain, Size: 751 bytes --]
Hi Forest,
On 03/28/2013 10:36 AM, Forest Bond wrote:
> Hi Denis,
>
> On Thu, Mar 28, 2013 at 09:55:25AM -0500, Denis Kenzior wrote:
>> Hi Forest,
>>
>> On 03/28/2013 09:22 AM, Forest Bond wrote:
>>> From: Forest Bond<forest.bond@rapidrollout.com>
>>>
>>> ---
>>> src/modem.c | 15 +++++++++++++--
>>> 1 files changed, 13 insertions(+), 2 deletions(-)
>>>
>>
>> I would actually be okay with this as an interim solution, but see
>> my comments to patch 3.
>
> Great, glad to hear it.
>
> Quick question: Once this change is in place, set_online is not called for CDMA
> devices. Should I kill the CDMA-only code paths there?
I don't recall off hand which code paths these are. Can you elaborate?
Regards,
-Denis
next prev parent reply other threads:[~2013-03-28 16:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-28 14:21 [RFC PATCH 0/3] Fix CDMA support with composite plugins Forest Bond
2013-03-28 14:22 ` [RFC PATCH 1/3] modem: Allow setting boolean properties Forest Bond
2013-03-28 14:52 ` Denis Kenzior
2013-03-28 14:22 ` [RFC PATCH 2/3] modem: Support modem property "AlwaysOnline" Forest Bond
2013-03-28 14:55 ` Denis Kenzior
2013-03-28 15:36 ` Forest Bond
2013-03-28 16:05 ` Denis Kenzior [this message]
2013-03-28 16:33 ` Forest Bond
2013-03-28 14:22 ` [RFC PATCH 3/3] huawei: Set property "AlwaysOnline" for CDMA modems Forest Bond
2013-03-28 14:54 ` Denis Kenzior
2013-03-28 15:34 ` Forest Bond
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51546A52.70405@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox