From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH] Fix gprs provisioning for some SIM (non-USIM) cards
Date: Wed, 16 Oct 2013 10:57:47 -0500 [thread overview]
Message-ID: <525EB77B.4030505@gmail.com> (raw)
In-Reply-To: <525E765D.1050205@southpole.se>
[-- Attachment #1: Type: text/plain, Size: 906 bytes --]
Hi Jonas,
On 10/16/2013 06:19 AM, Jonas Bonn wrote:
> On 10/16/2013 12:55 PM, Alfonso Sanchez-Beato wrote:
>> In some cases the field MNC length in EFad is not present. MNC can
>> have either 2 or 3 digits depending on the MCC: we will try with
>> those 2 lengths when searching in the database for this corner case
>> (this situation can happen for SIMs (non-USIM), as MNC lenght field
>> is not mandatory for them - see 3gpp TS 51.011)
>
> We've been here before...
>
> http://comments.gmane.org/gmane.comp.handhelds.ofono/13552
>
> Something like this is definitely needed... SIM's from at least one
> carrier in Sweden fail to provide the MNC length.
>
Feel free to improve your patch to be a bit more pedantic:
- checking for length == 3
- making sure that EFphase was set to something sane.
I might be convinced to default to MNC length 2 in that case
Regards,
-Denis
next prev parent reply other threads:[~2013-10-16 15:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-16 10:55 [PATCH] Fix gprs provisioning for some SIM (non-USIM) cards Alfonso Sanchez-Beato
2013-10-16 11:19 ` Jonas Bonn
2013-10-16 15:57 ` Denis Kenzior [this message]
2013-10-16 17:50 ` Alfonso Sanchez-Beato
2013-10-16 22:35 ` Denis Kenzior
2013-10-17 16:20 ` Alfonso Sanchez-Beato
2013-10-17 19:52 ` Denis Kenzior
2013-10-23 10:20 ` Alfonso Sanchez-Beato
2013-10-24 0:48 ` Denis Kenzior
2013-10-16 15:37 ` Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=525EB77B.4030505@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox