Open Source Telephony
 help / color / mirror / Atom feed
From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH] Fix gprs provisioning for some SIM (non-USIM) cards
Date: Wed, 23 Oct 2013 19:48:52 -0500	[thread overview]
Message-ID: <52686E74.8010808@gmail.com> (raw)
In-Reply-To: <CACM4vuAb9G-SgSuRo-xf_DjuQ6bse5vxGYTQmXNZyAX+L+GbqQ@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1286 bytes --]

Hi Alfonso,

 > After thinking about different options, my proposition is:
>
> * Write a new plugin called mnclenght that will find the length of the
> MNC code based on the IMSI. It will use a DB of MCC/MNC
> correspondences and check some special cases for some operators (this
> is the approach taken in Android, btw).

Sounds good to me.

>
> * This plugin will be called by the sim core after reading the IMSI in
> case the MNC length has not been set before. If a valid MNC length is
> found, the MNC will be read from the IMSI and MobileNetworkCode
> property will be updated in dBus.
>

We shall have to see.  The only reason for exposing MCC/MNC to external 
applications is to streamline the manual user provisioning a bit.  E.g. 
if this information is provided, then some UI steps can be skipped by 
the user.  However, this information is optional.

> Would this approach be okay for going upstream?
>

In general I'd rather keep the information coming from plugins to the 
core to a minimum.  We shall decide this second point once I see the 
code.  The MCC->MNC length database would be useful regardless however, 
and can be used by the existing provisioning infrastructure.  So this 
part would definitely be welcome.

Regards,
-Denis

  reply	other threads:[~2013-10-24  0:48 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-16 10:55 [PATCH] Fix gprs provisioning for some SIM (non-USIM) cards Alfonso Sanchez-Beato
2013-10-16 11:19 ` Jonas Bonn
2013-10-16 15:57   ` Denis Kenzior
2013-10-16 17:50     ` Alfonso Sanchez-Beato
2013-10-16 22:35       ` Denis Kenzior
2013-10-17 16:20         ` Alfonso Sanchez-Beato
2013-10-17 19:52           ` Denis Kenzior
2013-10-23 10:20             ` Alfonso Sanchez-Beato
2013-10-24  0:48               ` Denis Kenzior [this message]
2013-10-16 15:37 ` Denis Kenzior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52686E74.8010808@gmail.com \
    --to=denkenz@gmail.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox