[PATCH 1/2] atmodem: add Sierra to be polled after entering pin

[PATCH 1/2] atmodem: add Sierra to be polled after entering pin

[Cedric Jehasse]

[-- Attachment #1: Type: text/plain, Size: 761 bytes --]

From: Cedric Jehasse <cedric.jehasse@softathome.com>

Sierra modem will return "CME ERROR: 14" when polled right after pin has
been entered. Use the existing vendor quirk to handle this.
---
 drivers/atmodem/sim.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/atmodem/sim.c b/drivers/atmodem/sim.c
index c128e33..054f548 100644
--- a/drivers/atmodem/sim.c
+++ b/drivers/atmodem/sim.c
@@ -1350,6 +1350,7 @@ static void at_pin_send_cb(gboolean ok, GAtResult *result,
 	case OFONO_VENDOR_ALCATEL:
 	case OFONO_VENDOR_HUAWEI:
 	case OFONO_VENDOR_SIMCOM:
+	case OFONO_VENDOR_SIERRA:
 		/*
 		 * On ZTE modems, after pin is entered, SIM state is checked
 		 * by polling CPIN as their modem doesn't provide unsolicited
-- 
1.9.2

[PATCH 2/2] atmodem: fix retries reporting from AT+CPINR

[Cedric Jehasse]

[-- Attachment #1: Type: text/plain, Size: 624 bytes --]

From: Cedric Jehasse <cedric.jehasse@softathome.com>

The retries array was not correctly filled in.
---
 drivers/atmodem/sim.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/atmodem/sim.c b/drivers/atmodem/sim.c
index 054f548..d6a0dcf 100644
--- a/drivers/atmodem/sim.c
+++ b/drivers/atmodem/sim.c
@@ -827,7 +827,7 @@ static void at_cpinr_cb(gboolean ok, GAtResult *result, gpointer user_data)
 
 		for (i = 1; i < len; i++) {
 			if (!strcmp(name, at_sim_name[i].name)) {
-				retries[i] = val;
+				retries[at_sim_name[i].type] = val;
 				break;
 			}
 		}
-- 
1.9.2

Re: [PATCH 1/2] atmodem: add Sierra to be polled after entering pin

[Denis Kenzior]

[-- Attachment #1: Type: text/plain, Size: 395 bytes --]

Hi Cedric,

On 02/02/2015 03:32 AM, Cedric Jehasse wrote:
> From: Cedric Jehasse <cedric.jehasse@softathome.com>
>
> Sierra modem will return "CME ERROR: 14" when polled right after pin has
> been entered. Use the existing vendor quirk to handle this.
> ---
>   drivers/atmodem/sim.c | 1 +
>   1 file changed, 1 insertion(+)
>

Patch has been applied, thanks.

Regards,
-Denis

Re: [PATCH 2/2] atmodem: fix retries reporting from AT+CPINR

[Denis Kenzior]

[-- Attachment #1: Type: text/plain, Size: 322 bytes --]

Hi Cedric,

On 02/02/2015 03:32 AM, Cedric Jehasse wrote:
> From: Cedric Jehasse <cedric.jehasse@softathome.com>
>
> The retries array was not correctly filled in.
> ---
>   drivers/atmodem/sim.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>

Patch has been applied, thanks.

Regards,
-Denis