Open Source Telephony
 help / color / mirror / Atom feed
From: Tommi Kenakkala <tommi.kenakkala@tieto.com>
To: ofono@ofono.org
Subject: Re: ofono Digest, Vol 74, Issue 7
Date: Mon, 22 Jun 2015 16:50:24 +0300	[thread overview]
Message-ID: <558812A0.9010604@tieto.com> (raw)
In-Reply-To: <mailman.1.1434654002.31324.ofono@ofono.org>

[-- Attachment #1: Type: text/plain, Size: 853 bytes --]

On 18.06.2015 22:00, ofono-request(a)ofono.org wrote:
> Date: Wed, 17 Jun 2015 23:07:53 -0500
 > From: Denis Kenzior
> <denkenz@gmail.com> To: ofono(a)ofono.org Cc: tommi.kenakkala(a)tieto.com
> Subject: Re: [PATCH 1/2] [sim] Emit LockedPins after pin_type is queried
> Message-ID: <55824419.5080703@gmail.com> Content-Type: text/plain;
> charset=ISO-8859-1; format=flowed
...
> There is a subtlety here.  OFONO_SIM_PASSWORD_NONE is never considered
> when emitting LockedPins.  However, in this proposal you can trigger a
> LockedPins emission even if there's no PIN set.
>
> To me it seems like emitting LockedPins with an empty value seems
> unnecessary.  Thoughts?
...
 > Regards,
 > -Denis

I agree. Initially there was a though but now I don't see any extra 
value on emitting it. Updated patch submitted.
Thanks,
-- 
Tommi

           reply	other threads:[~2015-06-22 13:50 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <mailman.1.1434654002.31324.ofono@ofono.org>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=558812A0.9010604@tieto.com \
    --to=tommi.kenakkala@tieto.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox