Re: ofono Digest, Vol 74, Issue 7

Re: ofono Digest, Vol 74, Issue 7

[Tommi Kenakkala]

[-- Attachment #1: Type: text/plain, Size: 853 bytes --]

On 18.06.2015 22:00, ofono-request(a)ofono.org wrote:
> Date: Wed, 17 Jun 2015 23:07:53 -0500
 > From: Denis Kenzior
> <denkenz@gmail.com> To: ofono(a)ofono.org Cc: tommi.kenakkala(a)tieto.com
> Subject: Re: [PATCH 1/2] [sim] Emit LockedPins after pin_type is queried
> Message-ID: <55824419.5080703@gmail.com> Content-Type: text/plain;
> charset=ISO-8859-1; format=flowed
...
> There is a subtlety here.  OFONO_SIM_PASSWORD_NONE is never considered
> when emitting LockedPins.  However, in this proposal you can trigger a
> LockedPins emission even if there's no PIN set.
>
> To me it seems like emitting LockedPins with an empty value seems
> unnecessary.  Thoughts?
...
 > Regards,
 > -Denis

I agree. Initially there was a though but now I don't see any extra 
value on emitting it. Updated patch submitted.
Thanks,
-- 
Tommi