From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 2/3] Gobi: Enable SIM driver "manual" config
Date: Mon, 02 May 2016 10:13:40 -0500 [thread overview]
Message-ID: <57276EA4.1070306@gmail.com> (raw)
In-Reply-To: <1462200163-15827-2-git-send-email-m.chaplet@kerlink.fr>
[-- Attachment #1: Type: text/plain, Size: 1243 bytes --]
Hi Martin,
On 05/02/2016 09:42 AM, Martin Chaplet wrote:
> Let modem detect part overload default SIM driver by using an additional
> property named "Simdriver".
> It allows QMI modems with buggy UIM interface to be supported by forcing
> legacy driver.
> ---
> plugins/gobi.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/plugins/gobi.c b/plugins/gobi.c
> index 4daa459..09c9d95 100644
> --- a/plugins/gobi.c
> +++ b/plugins/gobi.c
> @@ -413,12 +413,16 @@ error:
> static void gobi_pre_sim(struct ofono_modem *modem)
> {
> struct gobi_data *data = ofono_modem_get_data(modem);
> + const char * simdriver;
>
> DBG("%p", modem);
>
> ofono_devinfo_create(modem, 0, "qmimodem", data->device);
>
> - if (data->features & GOBI_UIM)
> + simdriver = ofono_modem_get_string(modem,"Simdriver");
Can we name this ForceSimLegacy and make it a boolean?
> + if(simdriver != NULL)
> + ofono_sim_create(modem, 0, simdriver, data->device);
> + else if (data->features & GOBI_UIM)
> ofono_sim_create(modem, 0, "qmimodem", data->device);
> else if (data->features & GOBI_DMS)
> ofono_sim_create(modem, 0, "qmimodem-legacy", data->device);
>
Regards,
-Denis
next prev parent reply other threads:[~2016-05-02 15:13 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-02 14:42 [PATCH 1/3] udevng: Add usbmisc scan for QMI devices Martin Chaplet
2016-05-02 14:42 ` [PATCH 2/3] Gobi: Enable SIM driver "manual" config Martin Chaplet
2016-05-02 15:13 ` Denis Kenzior [this message]
2016-05-02 15:27 ` Martin Chaplet
2016-05-02 14:42 ` [PATCH 3/3] Add support for Sierra MC73xx QMI modems Martin Chaplet
2016-05-02 15:20 ` Denis Kenzior
2016-05-02 15:37 ` Martin Chaplet
2016-05-02 16:33 ` [PATCH 1/3] Gobi: Enable SIM driver forcing Martin Chaplet
2016-05-02 16:33 ` [PATCH 2/3] Udevng: Improve modem properties detection Martin Chaplet
2016-05-03 3:23 ` Denis Kenzior
2016-05-03 8:40 ` Martin Chaplet
2016-05-02 16:33 ` [PATCH 3/3] Add support for Sierra MC73xx QMI modems Martin Chaplet
2016-05-03 3:21 ` [PATCH 1/3] Gobi: Enable SIM driver forcing Denis Kenzior
2016-05-02 20:24 ` [PATCH 3/3] Add support for Sierra MC73xx QMI modems =?unknown-8bit?q?Bj=C3=B8rn?= Mork
2016-05-03 8:27 ` Martin Chaplet
2016-05-03 8:55 ` =?unknown-8bit?q?Bj=C3=B8rn?= Mork
2016-05-02 15:12 ` [PATCH 1/3] udevng: Add usbmisc scan for QMI devices Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57276EA4.1070306@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox